-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix datacenter value in case where the datacenter is defined in the conf file #18583
Conversation
@sgargan can you review please? |
@johnnycarlin @maguec are either of you able to review this? |
looks good shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it is enough to set self.current_dc on line 227:
if config.has_config('datacenter'):
self.current_dc = config.datacenter
if config.has_config('host'):
......
But your implementation works, so shipit :)
@jkhelil would you mind rebasing and we'll get this merged, thanks! |
@jkhelil Can you please rebase ? |
@jkhelil Thank you for your PR. Given that:
I'm going to close this. |
ISSUE TYPE
COMPONENT NAME
contrib/inventory/consul_io.py
ANSIBLE VERSION
SUMMARY
When datacenter is defined in the consul.ini conf file, kv groups are not retrieved for nodes, we should set self.current_dc with the right value to fix it