Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datacenter value in case where the datacenter is defined in the conf file #18583

Closed
wants to merge 1 commit into from

Conversation

jkhelil
Copy link

@jkhelil jkhelil commented Nov 22, 2016

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

contrib/inventory/consul_io.py

ANSIBLE VERSION
ansible 2.2.0.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

SUMMARY

When datacenter is defined in the consul.ini conf file, kv groups are not retrieved for nodes, we should set self.current_dc with the right value to fix it

@jctanner
Copy link
Contributor

@sgargan can you review please?

@jctanner
Copy link
Contributor

@johnnycarlin @maguec are either of you able to review this?

@sgargan
Copy link
Contributor

sgargan commented Nov 28, 2016

looks good shipit

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pullrequest labels Dec 13, 2016
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 16, 2016
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 3, 2017
Copy link
Contributor

@mliljedahl mliljedahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it is enough to set self.current_dc on line 227:

if config.has_config('datacenter'):
self.current_dc = config.datacenter
if config.has_config('host'):
......

But your implementation works, so shipit :)

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 1, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@calfonso
Copy link
Contributor

calfonso commented Jul 5, 2017

@jkhelil would you mind rebasing and we'll get this merged, thanks!

@ansibot ansibot added the inventory Inventory category label Jul 19, 2017
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 7, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 2, 2018
@Akasurde
Copy link
Member

@jkhelil Can you please rebase ?

@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 3, 2019
@gundalow
Copy link
Contributor

gundalow commented Sep 3, 2019

@jkhelil Thank you for your PR.
As part of reviewing the backlog of PRs we are looking at PRs older PRs that haven't been update

Given that:

  • Last commits were a long time ago
  • Rebase hasn't been done

I'm going to close this.
If you, or anyone else wants to continue with this work then please do feel free to create a fresh PR and @mention the previous reviewers in here.

@gundalow gundalow closed this Sep 3, 2019
@gundalow gundalow added pr_day Has been reviewed during a PR review Day and removed pr_day Has been reviewed during a PR review Day labels Sep 3, 2019
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. c:inventory/contrib_script inventory Inventory category needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. pr_day Has been reviewed during a PR review Day small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants