Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/win file symlink #19146

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Fix/win file symlink #19146

merged 1 commit into from
Feb 9, 2017

Conversation

jborean93
Copy link
Contributor

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_find

ANSIBLE VERSION
ansible 2.2.0.0
  config file =
  configured module search path = Default w/o overrides
SUMMARY

Added in checks to help with deleting broken symlinks, this is for ansible/ansible-modules-core#5120 after repo merge

This was referenced Dec 10, 2016
Closed
Closed
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pullrequest module This issue/PR relates to a module. windows Windows community labels Dec 13, 2016
@jborean93
Copy link
Contributor Author

@nitzmahone and @jhawkesworth this is the PR from pre repo merge when fixing up deleting broken symlinks. Please let me know if you wish for any more changes.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 16, 2016
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 19, 2016
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 2, 2017
@jimi-c jimi-c removed the plugin label Jan 4, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jan 5, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 29, 2017
@jborean93
Copy link
Contributor Author

@nitzmahone are you able to have a look at this PR to see if there were any more outstanding changes you had, I was hoping to get this in before 2.3 is in.

@dagwieers
Copy link
Contributor

@jborean93 I would like to see integration tests for this module to ensure it is working correctly for the use-case you fixed.

@jborean93
Copy link
Contributor Author

Hey @dagwieers thanks for having a look at this. The integration tests are already added under line 489-506 of the win_file test. Let me know if you see any issues.

@dagwieers
Copy link
Contributor

@jborean93 It is not my day apparently... Well done !

shipit

@jborean93
Copy link
Contributor Author

@dagwieers no worries I will get started on the other comments you have left. Thanks very much for having a look at these all. If you need anything to review just let me know :)

@nitzmahone nitzmahone merged commit 1c885cb into ansible:devel Feb 9, 2017
@jborean93 jborean93 deleted the fix/win_file-symlink branch February 9, 2017 23:28
@jhawkesworth jhawkesworth mentioned this pull request Feb 13, 2017
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees

@jhawkesworth jhawkesworth

Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jborean93 @dagwieers @nitzmahone @jimi-c @bcoca @ansibot @jhawkesworth