[win_chocolatey]Support for Side by side installs

[alex3305]

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

win_chocolatey

ANSIBLE VERSION

ansible 2.2.0.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

SUMMARY

This commit adds support for side by side installations of the different
versions of the same Chocolatey package in Ansible.

Internally the -m flag will be set when running the choco.exe install *
command. This will make Chocolatey disregard the currently installed
version and thus not upgrade, but install it side-by-side.

This change will probably be unsupported by some packages and maybe there
will be a need to provide a path to Ansible's win_chocolatey module, so it
is easier to manage multiple side-by-side installations of the same
package.

[ansibot]

cc @smadam813
click here for bot help

[ansibot]

cc @nitzmahone
click here for bot help

[lucalandi]

Can we get an update on this ? It's a really useful feature and I don't find any other way to inject it from win_chocolatey.

[dagwieers]

I still see 121 files changed :-/

[alex3305]

@dagwieers fixed that. Never used rebase before, sorry about that.

[mattclay]

CI failure in integration tests:

{
"changed": false, 
"failed": true, 
"module_stderr": "At line:180 char:37\r\n+         [bool]$allowmultipleversions\r\n+                                     ~\r\nMissing ')' in function parameter list.\r\n\r\nAt line:156 char:1\r\n+ {\r\n+ ~\r\nMissing closing '}' in statement block.\r\n\r\nAt line:184 char:5\r\n+     )\r\n+     ~\r\nUnexpected token ')' in expression or statement.\r\n\r\nAt line:260 char:1\r\n+ }\r\n+ ~\r\nUnexpected token '}' in expression or statement.\r\n\r\nAt line:293 char:35\r\n+     if (Choco-IsInstalled $package) -and (-not $allowmultipleversions))\r\n+                                   ~\r\nMissing statement block after if ( condition ).\r\n\r\nAt line:263 char:1\r\n+ {\r\n+ ~\r\nMissing closing '}' in statement block.\r\n\r\nAt line:293 char:71\r\n+     if (Choco-IsInstalled $package) -and (-not $allowmultipleversions))\r\n+                                                                       ~\r\nUnexpected token ')' in expression or statement.\r\n\r\nAt line:373 char:1\r\n+ }\r\n+ ~\r\nUnexpected token '}' in expression or statement.\r\n\r\n\r\n    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordEx \r\n   ception\r\n    + FullyQualifiedErrorId : MissingEndParenthesisInFunctionParameterList\r\n \r\n\r\n", 
"module_stdout": "", 
"msg": "MODULE FAILURE", 
"rc": 1
}

[alex3305]

@mattclay Fixed that for ya. The rebase went completely wrong. I had trouble rebasing the thing. Normally at work we use merge instead of rebase. Kinda confusing for the first time :). Should work now.

[jborean93]

I believe there is a call to Choco-Upgrade that needs to have this new parameter passed in now. Once you fix up the minor things I'll do a test before merging.

[jborean93]

Why did this change, should there be more lines to add allowmultipleversions to the 11th position?

[jborean93]

@alex3305, just tried this out locally and it doesn't work. When trying to install a newer version of putty side by side it just returns without a change. I believe the check Choco-IsInstalled is returning true and then just exists the function.

[ansibot]

cc @ptemplier
click here for bot help