Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-py 2.0 compatibility #19633

Closed
wants to merge 3 commits into from
Closed

docker-py 2.0 compatibility #19633

wants to merge 3 commits into from

Conversation

dariko
Copy link
Contributor

@dariko dariko commented Dec 22, 2016

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker modules

ANSIBLE VERSION
ansible 2.3.0 (dockerpy_2 a5e4f50d0f) last updated 2016/12/22 09:46:29 (GMT +200)
SUMMARY

Add support for python library docker-py >= 2.0.0, which has been renamed in pip as [docker] and introduces some breaking changes.
release notes

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 cloud docker feature_pull_request module This issue/PR relates to a module. c:module_utils/ needs_triage Needs a first human triage before being processed. labels Dec 22, 2016
@dariko dariko mentioned this pull request Dec 23, 2016
Merged
djmattyg007
djmattyg007 reviewed Dec 26, 2016
View reviewed changes
Copy link
Contributor

@djmattyg007 djmattyg007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be using four spaces for indentation.

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 26, 2016
@dariko
Copy link
Contributor Author

dariko commented Dec 26, 2016

@djmattyg007 thanks, I corrected the indentation

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 26, 2016
@dariko
Copy link
Contributor Author

dariko commented Dec 26, 2016

Shippable returned an error on a unarchive module test, on the first task:

- name: Ensure zip is present to create test archive (yum)
  yum: name=zip state=latest
  when: ansible_pkg_mgr  ==  'yum'

After syncing to 47c0c71 the tests run correctly.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 2, 2017
@jimi-c jimi-c removed the plugin label Jan 4, 2017
@abadger
Copy link
Contributor

abadger commented Jan 4, 2017

/cc @ryansb @chouseknecht @ryansb so that one of them can review and merge.

@abadger abadger added bugfix_pull_request and removed needs_triage Needs a first human triage before being processed. labels Jan 4, 2017
@ansibot ansibot added module_util needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 4, 2017
@ansibot ansibot added module_util committer_review In order to be merged, this PR must follow the certified review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Jan 5, 2017
@ryansb
Copy link
Contributor

ryansb commented Jan 18, 2017

Merged as e2a1ce2

@ryansb ryansb closed this Jan 18, 2017
@sivel sivel mentioned this pull request Jan 18, 2017
Closed
@shanedroid shanedroid mentioned this pull request May 9, 2017
Closed
@ansibot ansibot added feature This issue/PR relates to a feature request. bug This issue/PR relates to a bug. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djmattyg007 djmattyg007 djmattyg007 left review comments

@ryansb ryansb ryansb approved these changes

@bcoca bcoca Awaiting requested review from bcoca

@chouseknecht chouseknecht Awaiting requested review from chouseknecht

Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. c:module_utils/ cloud docker feature This issue/PR relates to a feature request. module_util module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dariko @abadger @ryansb @djmattyg007 @jimi-c @ansibot