Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_reg_stat: Clean up parameter handling #21380

Merged
merged 1 commit into from
Feb 20, 2017

Conversation

dagwieers
Copy link
Contributor

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_reg_stat

ANSIBLE VERSION

v2.3

SUMMARY

Only minor changes.

@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2017

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. windows Windows community labels Feb 14, 2017
@jborean93
Copy link
Contributor

I take it you don't need to add the warnings to the return result?

shipit

@dagwieers
Copy link
Contributor Author

dagwieers commented Feb 14, 2017

I didn't see any warnings. But if you would need to "escalate" warnings, we now have Add-Warning and Add-DeprecationWarning functions that will add the required entry as part of the call. So it shouldn't be needed in the standard $result hash.

PS We also ensured that empty warnings in the output is properly cleaned up, so it's not a real problem anymore ;-)

@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2017

@SamLiu79 @timothyvandenbrande @blakfeld @brianlloyd @chrishoffman @jborean93 @joshludwig @petemounce @schwartzmx @smadam813 @WHenrik

The win_reg_stat module has only one maintainer and this request needs 2 shipits. As a maintainer of a module in the same namespace, you can add a shipit to help move this request along.

click here for bot help

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 14, 2017
@jhawkesworth
Copy link
Contributor

shipit

@jhawkesworth
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Feb 15, 2017

waiting_on: maintainer
module: win_reg_stat
supported_by: community
maintainers: jborean93
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits: 1
community_shipits: 0
ansible_shipits: 1
shipit_actors: jborean93 jhawkesworth

click here for bot help

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 15, 2017
@dagwieers
Copy link
Contributor Author

ready_for_review

@gundalow gundalow merged commit 3c45c93 into ansible:devel Feb 20, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.3 This issue/PR affects Ansible v2.3 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants