Fix reading role skeleton path from config/env #22252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI.get_opt() will only use the passed default value if an exception is raised while trying to read the option value from the parsed values. As a result, the C.GALAXY_ROLE_SKELETON value was never read. Instead of relying on the default value, we explicitly check to see if role_skeleton was set, and use C.GALAXY_ROLE_SKELETON if it isn't. This is tested by patching C.GALAXY_ROLE_SKELETON to point to the role skeleton in our test_data folder, and not supplying a role skeleton argument.
ansibot
added
affects_2.3
s-hertel
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
added
needs_rebase
|
It looks like this is fixed by the refactor that extracted all the config from constants.py into a yml file. Closing this PR. If someone wants this rebased against stable-2.3 I'd be willing to do it and re-open. |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
ansible-galaxy
ANSIBLE VERSION
SUMMARY
CLI.get_opt() will only use the passed default value if an exception is raised
while trying to read the option value from the parsed values. As a
result, the C.GALAXY_ROLE_SKELETON value was never read. Instead of
relying on the default value, we explicitly check to see if
role_skeleton was set, and use C.GALAXY_ROLE_SKELETON if it isn't.
This is tested by patching C.GALAXY_ROLE_SKELETON to point to the role
skeleton in our test_data folder, and not supplying a role skeleton
argument.