Fix logic surrounding copy and remote_src in unarchive module #24732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix logic surrounding copy and remote_src, remote_src is preferred, make copy action plugin only. Fixes #23591
This is done by making
copy
an action plugin only argument and ensuring thatremote_src
is properly set.ISSUE TYPE
COMPONENT NAME
unarchive
ANSIBLE VERSION
ADDITIONAL INFORMATION
It seems the logic here has always been a little strange, and it was further broken in 7b197d8 by making
remote_src
action plugin only.The
mutually_exclusive
definition was removed, as it was already being handled in the action plugin, and would never apply in the module now.