Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic surrounding copy and remote_src in unarchive module #24732

Merged
merged 1 commit into from
May 23, 2017
Merged

Fix logic surrounding copy and remote_src in unarchive module #24732

merged 1 commit into from
May 23, 2017

Conversation

sivel
Copy link
Member

@sivel sivel commented May 17, 2017

SUMMARY

Fix logic surrounding copy and remote_src, remote_src is preferred, make copy action plugin only. Fixes #23591

This is done by making copy an action plugin only argument and ensuring that remote_src is properly set.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

unarchive

ANSIBLE VERSION
devel
ADDITIONAL INFORMATION

It seems the logic here has always been a little strange, and it was further broken in 7b197d8 by making remote_src action plugin only.

The mutually_exclusive definition was removed, as it was already being handled in the action plugin, and would never apply in the module now.

@sivel sivel mentioned this pull request May 17, 2017
Closed
@maximede
Copy link
Contributor

LGTM.
Tested twice, once with remote_src: true and once with copy: false . It downloaded the file correctly both time

@ansibot
Copy link
Contributor

ansibot commented May 17, 2017

cc @dagwieers @pileofrogs
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request c:plugins/action core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels May 17, 2017
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label May 17, 2017
@sivel
Copy link
Member Author

sivel commented May 19, 2017

@bcoca I did some more investigating. The 3 issues I saw in regards to this were all reports against 2.4. The change where remote_src was being stripped only appears to devel, and not stable-2.3.

I've tested in stable-2.3 and confirmed everything there is working as expected. This is only needed for devel/2.4.

@abadger abadger merged commit 4ac135c into ansible:devel May 23, 2017
@abadger
Copy link
Contributor

abadger commented May 23, 2017

Merged to devel.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. c:plugins/action core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unarchive: unable to unpack tar.gz from URI with python3 interpreter
5 participants
@sivel @maximede @ansibot @abadger @gundalow