Edit pass for relocated community documentation. #28368

dharmabumstead · 2017-08-17T20:46:17Z

SUMMARY

ISSUE TYPE

Feature Pull Request
New Module Pull Request
Bugfix Pull Request
Docs Pull Request

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

gregdek · 2017-08-17T20:54:08Z

Thumbs up from me.

Some of this content is still incorrect -- e.g. the triage bot now runs more or less continually, I believe -- but we'll pick those things out in subsequent pull requests. (Hopefully at a working session at AnsibleFest.)

ansibot · 2017-08-17T22:00:54Z

The test ansible-test sanity --test rstcheck failed with the following error:

docs/docsite/rst/community/development_process.rst:19:0: Title underline too short.

click here for bot help

samdoran · 2017-08-18T03:54:45Z

Making a bunch of improvements to this that will definitely need some review. I believe I made the bot workflow statements more accurate as well as corrected some outdated links. It would also be nice to have @jctanner review the bot workflow to make sure it is accurate.

samdoran · 2017-08-18T04:30:37Z

Ready to be reviewed.

gundalow · 2017-08-18T07:56:46Z

docs/docsite/rst/community/communication.rst


 `Ansible Container List <https://groups.google.com/forum/#!forum/ansible-container>`_ is for users and developers of the Ansible Container project.

 `Ansible Lockdown List <https://groups.google.com/forum/#!forum/ansible-lockdown>`_ is for all things related to Ansible Lockdown projects, including DISA STIG automation and CIS Benchmarks.

-To subscribe to a group from a non-google account, you can send an email to the subscription address requesting the subscription. For example: ansible-devel+subscribe@googlegroups.com
+To subscribe to a group from a non-Google account, you can send an email to the subscription address requesting the subscription. For example: ansible-devel+subscribe@googlegroups.com

 IRC Channel
 -----------


I'll update this to list all the IRC channels.
We can then replace every other reference to mailing lists and IRC with a link to this page.
This would include deleting the list on github.com/ansible/community

gundalow · 2017-08-18T10:54:33Z

Needs updating so the headings are consistent (as per style guide)
I think we should add .. contents:: Topics on the top of any page with more than two headings, makes it easier to find info
Do we want anchors on any of these headings?
I've added the list of IRC channels. Can all other references to IRC and mailing lists be deleted and replaced with a link to this page

gundalow · 2017-08-19T12:51:13Z

Can we please leave this PR open for a bit longer. I plan to hack on this during the flight to RDU. Thanks

dharmabumstead · 2017-08-19T21:57:51Z

Absolutely.

mattclay · 2017-08-21T17:50:27Z

Closing and re-opening to trigger CI.

ansibot · 2017-08-21T18:07:38Z

The test ansible-test sanity --test rstcheck failed with the following errors:

docs/docsite/rst/community/maintainers.rst:12:0: Mismatch: both interpreted text role prefix and reference suffix.
docs/docsite/rst/community/reporting_bugs_and_features.rst:1:0: Title overline & underline mismatch.

click here for bot help

gregdek · 2017-08-30T15:43:26Z

What do we need to do to get this pushed and live?

gregdek · 2017-08-30T15:43:50Z

@dharmabumstead I think we're waiting on one last review from you.

dharmabumstead · 2017-08-30T17:45:00Z

I'll do a last edit pass today. Looks like we've got merge conflicts that will need to be resolved though.

Fixed improper link syntax Change links to point to new documents Changed Ansibot to Ansibullbot Clarified workflow Change formatting on commans and tags

Add Contents Use correct headings

samdoran · 2017-08-30T20:17:49Z

Rebased.

dharmabumstead · 2017-08-30T20:41:54Z

Sweet. I'll get the edit pass done this afterlunch.

…

On Wed, Aug 30, 2017 at 1:18 PM, Sam Doran ***@***.***> wrote: Rebased. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#28368 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABmuZbd17ZA90_UyagTCW_Z5y8e7C5Wnks5sdcN8gaJpZM4O6ynY> .

dharmabumstead

@gregdek and @gundalow - please see comments.

dharmabumstead · 2017-08-30T22:28:13Z

docs/docsite/rst/community/development_process.rst

+   -  If the maintainer says ``shipit``, the pull request is labeled **shipit**, whereupon the Core team assesses it for final merge.
+   -  If the maintainer says ``needs_info``, the pull request is labeled **needs_info** and the submitter is asked for more info.
+   -  If the maintainer says **needs_revision**, the pull request is labeled **needs_revision** and the submitter is asked to fix some things.
+   -  If the pull request is labeled **needs_revision** or **needs_info** and has received comments from the submitter...TODO: what happens here?


This sentence was left unfinsished. What happens in this case?

This is out of date anyway and will need to be thoroughly revised when we have time. For now, let's just remove that bullet point.

dharmabumstead · 2017-08-30T22:29:29Z

docs/docsite/rst/community/how_can_I_help.rst


 When you become a power user, your ability and opportunities to help the Ansible project in other ways will multiply quickly.

 Ask and answer questions online
 -------------------------------

-There are many forums online where Ansible users ask and answer questions. Reach out and communicate with your fellow Ansible users. Ask good questions, and give good answers. 
+There are many forums online where Ansible users ask and answer questions. Reach out and communicate with your fellow Ansible users. Ask good questions, and give good answers.


Are there bad questions? Please consider rephrasing.

There are bad questions, actually. We could consider linking to this: http://www.catb.org/esr/faqs/smart-questions.html

But for now, let's just delete that "Ask" sentence.

dharmabumstead · 2017-08-30T22:29:57Z

docs/docsite/rst/community/how_can_I_help.rst


 Participate in your local meetup
 --------------------------------

-There are Ansible meetups `all over the world <https://www.meetup.com/topics/ansible/>`. Join your local meetup. Attend regularly. Ask good questions. Volunteer to give a presentation about how you use Ansible. 
+There are Ansible meetups `all over the world <https://www.meetup.com/topics/ansible/>`_. Join your local meetup. Attend regularly. Ask good questions. Volunteer to give a presentation about how you use Ansible.


Ibid. Are there bad questions? Please consider not using this phrase.

Remove "bad".

dharmabumstead · 2017-08-30T22:31:24Z

docs/docsite/rst/community/maintainers.rst

@@ -41,7 +45,7 @@ Issues for modules are routed to their maintainers via an automated process. Thi
 PR Workflow
 -----------

-Automated routing of pull requests is handled by a tool called [Ansibot](https://github.com/ansible/ansibullbot). (You could say that he moooo-ves things around.) 
+Automated routing of pull requests is handled by a tool called [Ansibot](https://github.com/ansible/ansibullbot). (You could say that he moooo-ves things around.)


Cute, but adding stuff like this to the documentation is creating a localization nightmare further down the road. Please remove.

OK, cut the pun.

dharmabumstead

Edit and review finished. Good to merge.

* Edit pass for relocated community documentation. * Updated info on Ansibullbot Fixed improper link syntax Change links to point to new documents Changed Ansibot to Ansibullbot Clarified workflow Change formatting on commans and tags * Update communication.rst Add Contents Use correct headings * Update communication.rst * Topics, remove whitespace, codeofconduct * Formatting * Correct heading * Update maintainers.rst * Minor edits and a request for more info * Removed some hard-to-localize wording. * Removed incomplete sentence * Minor edits per review

ansibot added affects_2.4 This issue/PR affects Ansible v2.4 feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 17, 2017

dharmabumstead mentioned this pull request Aug 17, 2017

Consolidate Community on docs.ansible.com/ansible/community ansible/community#169

Closed

ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Aug 17, 2017

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 17, 2017

nitzmahone removed the needs_triage Needs a first human triage before being processed. label Aug 17, 2017

ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 18, 2017

dharmabumstead requested review from gregdek and gundalow August 18, 2017 03:22

dharmabumstead requested a review from jctanner August 18, 2017 03:58

dharmabumstead self-assigned this Aug 18, 2017

gundalow reviewed Aug 18, 2017

View reviewed changes

gundalow mentioned this pull request Aug 18, 2017

Update docs to reflect new MAINTAINERS location #27906

Closed

gundalow mentioned this pull request Aug 19, 2017

Code of conduct contact address incorrect ansible/community#222

Closed

mattclay closed this Aug 21, 2017

mattclay reopened this Aug 21, 2017

dharmabumstead and others added 8 commits August 30, 2017 16:15

Edit pass for relocated community documentation.

06b18c0

Updated info on Ansibullbot

e82be4a

Fixed improper link syntax Change links to point to new documents Changed Ansibot to Ansibullbot Clarified workflow Change formatting on commans and tags

Update communication.rst

2aaf090

Add Contents Use correct headings

Update communication.rst

2d009a7

Topics, remove whitespace, codeofconduct

6abda78

Formatting

0975d2e

Correct heading

3ac5213

Update maintainers.rst

1410aa1

Minor edits and a request for more info

98d04e3

dharmabumstead commented Aug 30, 2017

View reviewed changes

dharmabumstead added 3 commits August 31, 2017 11:23

Removed some hard-to-localize wording.

3b91a95

Removed incomplete sentence

9991e3e

Minor edits per review

73fb98c

dharmabumstead commented Aug 31, 2017

View reviewed changes

dharmabumstead merged commit b146e17 into ansible:devel Aug 31, 2017

ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018

ansible locked and limited conversation to collaborators Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Edit pass for relocated community documentation. #28368

Edit pass for relocated community documentation. #28368

dharmabumstead commented Aug 17, 2017

gregdek commented Aug 17, 2017

ansibot commented Aug 17, 2017

samdoran commented Aug 18, 2017

samdoran commented Aug 18, 2017

gundalow Aug 18, 2017

gundalow commented Aug 18, 2017

gundalow commented Aug 19, 2017

dharmabumstead commented Aug 19, 2017

mattclay commented Aug 21, 2017

ansibot commented Aug 21, 2017

gregdek commented Aug 30, 2017

gregdek commented Aug 30, 2017

dharmabumstead commented Aug 30, 2017

samdoran commented Aug 30, 2017

dharmabumstead commented Aug 30, 2017 via email

dharmabumstead left a comment

dharmabumstead Aug 30, 2017

gregdek Aug 31, 2017

dharmabumstead Aug 30, 2017

gregdek Aug 31, 2017

dharmabumstead Aug 30, 2017

gregdek Aug 31, 2017

dharmabumstead Aug 30, 2017

gregdek Aug 31, 2017

dharmabumstead left a comment

Edit pass for relocated community documentation. #28368

Edit pass for relocated community documentation. #28368

Conversation

dharmabumstead commented Aug 17, 2017

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

gregdek commented Aug 17, 2017

ansibot commented Aug 17, 2017

samdoran commented Aug 18, 2017

samdoran commented Aug 18, 2017

Choose a reason for hiding this comment

gundalow commented Aug 18, 2017

gundalow commented Aug 19, 2017

dharmabumstead commented Aug 19, 2017

mattclay commented Aug 21, 2017

ansibot commented Aug 21, 2017

gregdek commented Aug 30, 2017

gregdek commented Aug 30, 2017

dharmabumstead commented Aug 30, 2017

samdoran commented Aug 30, 2017

dharmabumstead commented Aug 30, 2017 via email

dharmabumstead left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dharmabumstead left a comment

Choose a reason for hiding this comment