Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure acs module (azure_rm_acs) #28416

Closed
wants to merge 73 commits into from
Closed

Azure acs module (azure_rm_acs) #28416

wants to merge 73 commits into from

Conversation

julienstroheker
Copy link
Contributor

@julienstroheker julienstroheker commented Aug 18, 2017

SUMMARY
  • Adding the the azure_rm_acs module
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • azure_rm_acs.py
ANSIBLE VERSION
ansible 2.4.0 (az-acs e37e15468b) last updated 2017/08/18 00:14:15 (GMT +000)
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /app/ansible/lib/ansible
  executable location = /app/ansible/bin/ansible
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

TO DO before the merge :

  • Clean the logs call
  • Add docstring and comments some decision in the code
  • Improve Int. Tests
  • Lint

@ansibot
Copy link
Contributor

ansibot commented Aug 18, 2017

@julienstroheker this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.4 This issue/PR affects Ansible v2.4 azure cloud merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Aug 18, 2017
John McEleney and others added 4 commits August 18, 2017 22:08
- Changed zone_name to name - Changed cluster_name to cluster - Changed pod_name to pod - Corrected tags type in docs - Remove unneeded returns - Other simplifications
cs_storage_pool: rm CloudStackException dependency

cs_storage_pool: fix UnboundLocalError in check mode
local variable 'pool' referenced before assignment
*  Add aggregate validation for eos DI modules
*  Doc change to add aggregate examples
@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Aug 18, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 18, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc azure_rm_acs azure_rm_availabilityset azure_rm_deployment azure_rm_networkinterface azure_rm_networkinterface_facts azure_rm_publicipaddress azure_rm_publicipaddress_facts azure_rm_resourcegroup azure_rm_resourcegroup_facts azure_rm_securitygroup azure_rm_securitygroup_facts azure_rm_storageaccount azure_rm_storageaccount_facts azure_rm_storageblob azure_rm_subnet azure_rm_virtualmachine azure_rm_virtualmachineimage_facts azure_rm_virtualnetwork azure_rm_virtualnetwork_facts" returned exit status 1.
>>> Standard Error
ERROR! module azure_rm_acs missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc azure_rm_acs azure_rm_availabilityset azure_rm_deployment azure_rm_networkinterface azure_rm_networkinterface_facts azure_rm_publicipaddress azure_rm_publicipaddress_facts azure_rm_resourcegroup azure_rm_resourcegroup_facts azure_rm_securitygroup azure_rm_securitygroup_facts azure_rm_storageaccount azure_rm_storageaccount_facts azure_rm_storageblob azure_rm_subnet azure_rm_virtualmachine azure_rm_virtualmachineimage_facts azure_rm_virtualnetwork azure_rm_virtualnetwork_facts" returned exit status 1.
>>> Standard Error
ERROR! module azure_rm_acs missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc azure_rm_acs azure_rm_availabilityset azure_rm_deployment azure_rm_networkinterface azure_rm_networkinterface_facts azure_rm_publicipaddress azure_rm_publicipaddress_facts azure_rm_resourcegroup azure_rm_resourcegroup_facts azure_rm_securitygroup azure_rm_securitygroup_facts azure_rm_storageaccount azure_rm_storageaccount_facts azure_rm_storageblob azure_rm_subnet azure_rm_virtualmachine azure_rm_virtualmachineimage_facts azure_rm_virtualnetwork azure_rm_virtualnetwork_facts" returned exit status 1.
>>> Standard Error
ERROR! module azure_rm_acs missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc azure_rm_acs azure_rm_availabilityset azure_rm_deployment azure_rm_networkinterface azure_rm_networkinterface_facts azure_rm_publicipaddress azure_rm_publicipaddress_facts azure_rm_resourcegroup azure_rm_resourcegroup_facts azure_rm_securitygroup azure_rm_securitygroup_facts azure_rm_storageaccount azure_rm_storageaccount_facts azure_rm_storageblob azure_rm_subnet azure_rm_virtualmachine azure_rm_virtualmachineimage_facts azure_rm_virtualnetwork azure_rm_virtualnetwork_facts" returned exit status 1.
>>> Standard Error
ERROR! module azure_rm_acs missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/module_utils/azure_rm_common.py:716:1: W391 blank line at end of file
lib/ansible/modules/cloud/azure/azure_rm_acs.py:60:78: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:98:72: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:99:83: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:134:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:155:161: E501 line too long (380 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:167:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:179:161: E501 line too long (380 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:200:161: E501 line too long (380 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:210:92: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:211:97: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:212:109: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:226:161: E501 line too long (374 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:238:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:258:80: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:259:74: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:268:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:276:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:281:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:287:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:293:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:301:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:307:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:312:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:317:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:334:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:341:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:349:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:355:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:361:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:375:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:440:54: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_acs.py:441:54: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_acs.py:488:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:489:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:494:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:494:161: E501 line too long (179 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:495:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:497:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:498:21: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:499:21: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:502:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:502:161: E501 line too long (174 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:503:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:505:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:517:161: E501 line too long (227 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:526:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:527:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:528:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:529:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:530:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:531:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:532:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:533:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:534:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:537:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:552:66: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:567:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:569:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:569:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:570:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:570:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:571:33: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:571:35: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:572:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:572:40: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:573:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:573:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:574:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:574:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:575:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:575:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:576:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:576:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:587:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:598:98: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:600:64: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:617:98: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:619:64: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:644:11: W292 no newline at end of file

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/cloud/azure/azure_rm_acs.py:53:20: E302 DOCUMENTATION is not valid YAML
lib/ansible/modules/cloud/azure/azure_rm_acs.py:145:17: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint failed with the following error:

test/integration/targets/azure_rm_acs/tasks/main.yml:6:1: syntax error: expected '<document start>', but found '<block sequence start>'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 18, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc azure_rm_acs azure_rm_availabilityset azure_rm_deployment azure_rm_networkinterface azure_rm_networkinterface_facts azure_rm_publicipaddress azure_rm_publicipaddress_facts azure_rm_resourcegroup azure_rm_resourcegroup_facts azure_rm_securitygroup azure_rm_securitygroup_facts azure_rm_storageaccount azure_rm_storageaccount_facts azure_rm_storageblob azure_rm_subnet azure_rm_virtualmachine azure_rm_virtualmachineimage_facts azure_rm_virtualnetwork azure_rm_virtualnetwork_facts" returned exit status 1.
>>> Standard Error
ERROR! module azure_rm_acs missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc azure_rm_acs azure_rm_availabilityset azure_rm_deployment azure_rm_networkinterface azure_rm_networkinterface_facts azure_rm_publicipaddress azure_rm_publicipaddress_facts azure_rm_resourcegroup azure_rm_resourcegroup_facts azure_rm_securitygroup azure_rm_securitygroup_facts azure_rm_storageaccount azure_rm_storageaccount_facts azure_rm_storageblob azure_rm_subnet azure_rm_virtualmachine azure_rm_virtualmachineimage_facts azure_rm_virtualnetwork azure_rm_virtualnetwork_facts" returned exit status 1.
>>> Standard Error
ERROR! module azure_rm_acs missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc azure_rm_acs azure_rm_availabilityset azure_rm_deployment azure_rm_networkinterface azure_rm_networkinterface_facts azure_rm_publicipaddress azure_rm_publicipaddress_facts azure_rm_resourcegroup azure_rm_resourcegroup_facts azure_rm_securitygroup azure_rm_securitygroup_facts azure_rm_storageaccount azure_rm_storageaccount_facts azure_rm_storageblob azure_rm_subnet azure_rm_virtualmachine azure_rm_virtualmachineimage_facts azure_rm_virtualnetwork azure_rm_virtualnetwork_facts" returned exit status 1.
>>> Standard Error
ERROR! module azure_rm_acs missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc azure_rm_acs azure_rm_availabilityset azure_rm_deployment azure_rm_networkinterface azure_rm_networkinterface_facts azure_rm_publicipaddress azure_rm_publicipaddress_facts azure_rm_resourcegroup azure_rm_resourcegroup_facts azure_rm_securitygroup azure_rm_securitygroup_facts azure_rm_storageaccount azure_rm_storageaccount_facts azure_rm_storageblob azure_rm_subnet azure_rm_virtualmachine azure_rm_virtualmachineimage_facts azure_rm_virtualnetwork azure_rm_virtualnetwork_facts" returned exit status 1.
>>> Standard Error
ERROR! module azure_rm_acs missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/module_utils/azure_rm_common.py:716:1: W391 blank line at end of file
lib/ansible/modules/cloud/azure/azure_rm_acs.py:60:78: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:98:72: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:99:83: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:134:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:155:161: E501 line too long (380 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:167:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:179:161: E501 line too long (380 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:200:161: E501 line too long (380 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:210:92: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:211:97: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:212:109: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:226:161: E501 line too long (374 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:238:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:258:80: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:259:74: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:268:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:276:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:281:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:287:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:293:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:301:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:307:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:312:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:317:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:334:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:341:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:349:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:355:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:361:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:375:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/azure/azure_rm_acs.py:440:54: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_acs.py:441:54: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_acs.py:488:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:489:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:494:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:494:161: E501 line too long (179 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:495:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:497:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:498:21: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:499:21: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:502:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:502:161: E501 line too long (174 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:503:21: E115 expected an indented block (comment)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:505:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:517:161: E501 line too long (227 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_acs.py:526:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:527:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:528:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:529:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:530:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:531:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:532:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:533:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:534:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_acs.py:537:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:552:66: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:567:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:569:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:569:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:570:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:570:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:571:33: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:571:35: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:572:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:572:40: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:573:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:573:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:574:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:574:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:575:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:575:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:576:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:576:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_acs.py:587:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:598:98: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:600:64: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:617:98: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:619:64: W291 trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_acs.py:644:11: W292 no newline at end of file

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/cloud/azure/azure_rm_acs.py:0:0: E305 DOCUMENTATION.options.tags.delete: extra keys not allowed @ data['options']['tags']['delete']. Got 'on-exit'
lib/ansible/modules/cloud/azure/azure_rm_acs.py:0:0: E305 DOCUMENTATION.options.tags.description: required key not provided @ data['options']['tags']['description']. Got None
lib/ansible/modules/cloud/azure/azure_rm_acs.py:0:0: E305 DOCUMENTATION.options.tags.testing: extra keys not allowed @ data['options']['tags']['testing']. Got 'testing'
lib/ansible/modules/cloud/azure/azure_rm_acs.py:152:23: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint failed with the following error:

test/integration/targets/azure_rm_acs/tasks/main.yml:6:1: syntax error: expected '<document start>', but found '<block sequence start>'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2017

@julienstroheker this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added inventory Inventory category net_tools Net-tools category networking Network category virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) support:core This issue/PR relates to code supported by the Ansible Engineering Team. vmware VMware community windows Windows community and removed module This issue/PR relates to a module. new_module This PR includes a new module. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 22, 2017
@julienstroheker
Copy link
Contributor Author

Will reopen a clean one, sorry about that

@julienstroheker julienstroheker deleted the az-acs branch August 22, 2017 18:51
@dagwieers
Copy link
Contributor

@julienstroheker You can still fix the original branch and force-push to it. No need to close and open a new PR.

@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 azure cloud inventory Inventory category merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category networking Network category new_plugin This PR includes a new plugin. support:core This issue/PR relates to code supported by the Ansible Engineering Team. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) vmware VMware community windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.