Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sql_log_bin option to mysql_db module #28474

Closed
wants to merge 2 commits into from
Closed

Add sql_log_bin option to mysql_db module #28474

wants to merge 2 commits into from

Conversation

zaenk
Copy link

@zaenk zaenk commented Aug 21, 2017

SUMMARY

Added option to disable MySQL bin log for the connection used to create the database (like mysql_user module)

Implementation "based on" ansible/ansible-modules-core#2639 and "copy-pasted" from https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/database/mysql/mysql_user.py

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mysql_db module

ANSIBLE VERSION
ansible 2.3.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.6 (default, Jun 22 2015, 17:58:13) [GCC 4.8.2]
ADDITIONAL INFORMATION

@zaenk
Add sql_log_bin option to mysql_db module
a03369f 
Added option to disable MySQL bin log for the connection used to create the database (like mysql_user module)

Implementation based on:
- ansible/ansible-modules-core#2639
- https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/database/mysql/mysql_user.py
@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 21, 2017
@mattclay
Copy link
Member

Closing and re-opening to trigger CI.

@mattclay mattclay closed this Aug 21, 2017
@mattclay mattclay reopened this Aug 21, 2017
@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Aug 21, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2017

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/database/mysql/mysql_db.py:110:1: W293 blank line contains whitespace
lib/ansible/modules/database/mysql/mysql_db.py:112:13: W291 trailing whitespace
lib/ansible/modules/database/mysql/mysql_db.py:338:7: E111 indentation is not a multiple of four
lib/ansible/modules/database/mysql/mysql_db.py:339:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/database/mysql/mysql_db.py:0:0: E309 version_added for new option (sql_log_bin) should be 2.4. Currently 2.3
lib/ansible/modules/database/mysql/mysql_db.py:112:2: E311 EXAMPLES is not valid YAML

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 21, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Aug 21, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 21, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 29, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Feb 6, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 29, 2018
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:community This issue/PR relates to code supported by the Ansible community. labels Sep 18, 2018
@ansibot ansibot added needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 4, 2018
@ansibot ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Nov 10, 2018
@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Dec 31, 2018
@ansibot ansibot added the test This PR relates to tests. label Feb 3, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2019

cc @Xyon @bmalynovytch @michaelcoburn @Oneiroi @tolland
click here for bot help

@ansibot ansibot added the database Database category label Feb 19, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

cc @bmildren
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 3, 2019

cc @Alexander198961
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 19, 2019

cc @Andersson007
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

@zaenk Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added the needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. label Jul 31, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

@zaenk Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 8, 2019

cc @kurtdavis
click here for bot help

@gundalow
Copy link
Contributor

gundalow commented Sep 3, 2019

No one has looked at this since August 2017, so closing

@gundalow gundalow closed this Sep 3, 2019
@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 3, 2019
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 database Database category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. mysql needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. new_contributor This PR is the first contribution by a new community member. pr_day Has been reviewed during a PR review Day stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zaenk @mattclay @ansibot @gundalow @dagwieers @bcoca