mysql_user: add functionality to disable binlog when working with users

[grypyrg]

mysql_user: add functionality to disable binlog when working with users.

[gregdek]

Thanks @grypyrg. @marktheunissen please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit' or 'needs_revision' as appropriate.

[marktheunissen]

I am no longer the maintainer, as per #2653

[robynbergeron]

Thanks @grypyrg for this PR. Unfortunately, it is not mergeable in its current state due to merge conflicts. Please rebase your PR. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.

[tersmitten]

Nice addition. I think the problem is also present in the mysql_db module.

[tersmitten]

What about true/false and 1/0?

[Jmainguy]

@grypyrg @tersmitten So right now by default it always logs to bin, and this allows one to change to false, in order not to log stuff?

The benefit being gives the user the choice to free up some disk space?

[tersmitten]

No it's not really because of space. It's because sometimes you don't want to log queries to the binlog because they may break replication (if you run them multiple times, e.g. master-master) or you don't mind to create a difference (in users for instance) between machines

[Jmainguy]

@tersmitten Gotcha that makes sense

@grypyrg Would you mind rebasing?

[Jmainguy]

@grypyrg Think you could rebase this?

[grypyrg]

@Jmainguy : I'd like to but I don't have sufficient time at the moment to make a fix. I can try to do this in April, where I might have some spare time.

[Jmainguy]

@grypyrg No worries, I know how busy life can get. I will take a stab at rebasing this later this week (which should let the PR to get merged, and you will retain credit). I will update here once I have attempted it.

[Jmainguy]

Rebased over at #3112 I recommend closing this out, and continuing discussion over there.

[sivel]

Closing per above.