New lookup plugin snow: Lookup record data from Service-Now

[garbled1]

SUMMARY

Add a lookup plugin to search and find record data in Service-Now

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

lib/ansible/plugins/lookup/snow.py

ANSIBLE VERSION

ansible 2.5.0 (snow_lookup 7c7e7fbfd3) last updated 2017/09/23 20:33:55 (GMT +000)
  config file = None
  configured module search path = [u'/home/ec2-user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/ec2-user/ansible/lib/ansible
  executable location = /home/ec2-user/ansible/bin/ansible
  python version = 2.7.12 (default, Sep  1 2016, 22:14:00) [GCC 4.8.3 20140911 (Red Hat 4.8.3-9)]

ADDITIONAL INFORMATION

Plugin to allow scanning of records in service now.

---
- hosts: localhost
  connection: local
  vars:
    snow_context:
      table: incident
      instance: dev18962
      username: ansible_test
      password: my_password
      result_fields: [number]
  tasks:

    - name: Example of with_snow using record numbers and context
      debug:
        var: item
        verbosity: 0
      with_snow:
        - context: "{{snow_context}}"
        - INC0000055
        - INC0000054
    
    - name: check for incident numbered INC0000055
      debug: msg={{ lookup("snow", "INC0000055", context=snow_context) }}

    - name: Find all records in the incident table that are on hold, full variable definition
      debug: msg={{ lookup("snow", "2", instance='dev18962',
                    username='ansible_test', password='my_password',
                    table='incident', lookup_field='state', result_fields=['sys_id']) }}

[garbled1]

I'm not sure I understand why this is unstable. ?

[mattclay]

@garbled1 I've restarted the tests. The unstable result appears to be unrelated to your changes.

[garbled1]

Looks like the failure was something to do with installing an rpm on fedora and the pkg index. So unrelated I think?

[mattclay]

@garbled1 Yes, I've restarted CI again. Hopefully we won't hit the timeout this time.

[garbled1]

Looks like the CI is good on this one now, is it awaiting review?

[Akasurde]

@n3pjk Could you please review this and let me know ? Thanks

[n3pjk]

This looks like an alternative approach to snow_record_find (SRF). I think SRF has a more robust query building capability, and one can retrieve a set of SNow records and use the standard 'with: "{{ snow_records }}"' to process. Also, the login context is more tightly bound to the query in SRF.

In the conversation I had with @garbled1 re SRF, I recall him saying he didn't know why SRF wasn't also included. Perhaps this was another take on the same problem? I'm wondering if this is still needed.

In any case, this needs to have OAuth support added. It can't use ServiceNowClient as it isn't a full-fledged module.

[Akasurde]

Closing this in-favor of snow_record_find (SRF) module. @garbled1 Thanks for the contribution. @n3pjk Thanks for the review.