Temporary

[bcoca]

SUMMARY

normalize 'temporary dir handling'
this is partially done by also making shell plugins part of the new plugin config framework
fixes #31022

ISSUE TYPE

• Feature Pull Request
• Bugfix Pull Request

COMPONENT NAME

config

ANSIBLE VERSION

2.5

[abadger]

rebuild_merge

[abadger]

Merged for 2.5. @jborean93 and I will get our other changes to this (as promised in the review orin the branch) submitted against the devel.

[benjixx]

I'm getting the following traceback on devel, potentially due to this PR getting merged into devel:

Traceback (most recent call last):
  File "/home/travis/build/goodplay/goodplay/.tox/py27-ansibledevel/bin/ansible-playbook", line 118, in <module>
    exit_code = cli.run()
  File "/home/travis/build/goodplay/goodplay/.tox/py27-ansibledevel/lib/python2.7/site-packages/ansible/cli/playbook.py", line 122, in run
    results = pbex.run()
  File "/home/travis/build/goodplay/goodplay/.tox/py27-ansibledevel/lib/python2.7/site-packages/ansible/executor/playbook_executor.py", line 89, in run
    self._tqm.load_callbacks()
  File "/home/travis/build/goodplay/goodplay/.tox/py27-ansibledevel/lib/python2.7/site-packages/ansible/executor/task_queue_manager.py", line 190, in load_callbacks
    for callback_plugin in callback_loader.all(class_only=True):
  File "/home/travis/build/goodplay/goodplay/.tox/py27-ansibledevel/lib/python2.7/site-packages/ansible/plugins/loader.py", line 462, in all
    self._update_object(obj, name, path)
  File "/home/travis/build/goodplay/goodplay/.tox/py27-ansibledevel/lib/python2.7/site-packages/ansible/plugins/loader.py", line 346, in _update_object
    self._load_config_defs(name, path)
  File "/home/travis/build/goodplay/goodplay/.tox/py27-ansibledevel/lib/python2.7/site-packages/ansible/plugins/loader.py", line 217, in _load_config_defs
    if 'options' in dstring and isinstance(dstring['options'], dict):
TypeError: argument of type 'NoneType' is not iterable

[abadger]

@benjixx Please open a bug for that and link to this PR since you think it's probably a change in here somewhere. @bcoca is on vacation and I don't have time to look into the problem today but definitely don't want it to get forgotten.

[sivel]

@benjixx your traceback does not align with the current code in devel. The code in your traceback was changed in 869a3184922 which landed in September, far before this PR.