Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vagrant.py #31881

Closed
wants to merge 1 commit into from
Closed

Update vagrant.py #31881

wants to merge 1 commit into from

Conversation

standbyme
Copy link

Use list comprehension instead of loop.

SUMMARY

Use list comprehension instead of loop to make it straightforward.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

inventory/vagrant

ANSIBLE VERSION
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

contrib/inventory/vagrant.py:79:13: E201 whitespace after '['
contrib/inventory/vagrant.py:79:101: E231 missing whitespace after ','
contrib/inventory/vagrant.py:79:120: E202 whitespace before ']'

click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 c:inventory/contrib_script ci_verified Changes made in this PR are causing tests to fail. feature_pull_request inventory Inventory category needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 18, 2017
Update vagrant.py
8db5a7f 
Use list comprehension instead of loop.
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 18, 2017
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 19, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 27, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 4, 2017
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 28, 2017
@standbyme
Copy link
Author

@jborean93 How can I make this PR better? 😄

@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bot_closed c:inventory/contrib_script collection:community.general collection Related to Ansible Collections work feature This issue/PR relates to a feature request. inventory Inventory category needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@standbyme @ansibot @jborean93