Remove ip nameservers on ios_system/set_name_servers teardown #32239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why lookup source-interface, the only thing tested on that file is adding/removing name servers, no lookup is set.
|
@rcarrillocruz Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibot
added
affects_2.5
mkrizek
removed
the
needs_triage
trishnaguha
added a commit
that referenced
this pull request
Oct 30, 2017
* Introspect the management IP on ios_ping (#31571) On our CI we don't have external connectivity, so let's ping to the management interface IP. Also, ignore errors on the expected failures tests. (cherry picked from commit c75c4cb) * Remove duped authorize on ios_ping anchored tasks (#31572) Otherwise, we get warnings. (cherry picked from commit ac95eca) * Introspect platform before running ios tests * Add authorize * Fix quotes on ios_ping test (#32131) (cherry picked from commit ca115b0) * Fix lookup source tests on ios_system (#32254) In IOS-XE, you need to pass an interface to lookup-source, otherwise it fails with bad syntax. (cherry picked from commit 4b35793) * Remove ip nameservers on ios_system/set_name_servers teardown (#32239) Not sure why lookup source-interface, the only thing tested on that file is adding/removing name servers, no lookup is set. (cherry picked from commit 9752ce3) * fix conflict * Update CHANGELOG Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
dagwieers
added
ios
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why lookup source-interface, the only thing tested on that
file is adding/removing name servers, no lookup is set.