Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios_ping test fix #32342

Merged
merged 9 commits into from
Oct 30, 2017
Merged

ios_ping test fix #32342

merged 9 commits into from
Oct 30, 2017

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Oct 30, 2017 •
edited

SUMMARY

ios_ping
ios_user
ios_system

rcarrillocruz and others added 5 commits October 30, 2017 18:54
@rcarrillocruz @trishnaguha
Introspect the management IP on ios_ping (ansible#31571)
48bec94 
On our CI we don't have external connectivity, so let's ping to
the management interface IP.
Also, ignore errors on the expected failures tests.
(cherry picked from commit c75c4cb)
@rcarrillocruz @trishnaguha
Remove duped authorize on ios_ping anchored tasks (ansible#31572)
f4f27f8 
Otherwise, we get warnings.
(cherry picked from commit ac95eca)
@trishnaguha
Introspect platform before running ios tests
70e918d
@trishnaguha
Add authorize
8c0c687
@rcarrillocruz @trishnaguha
Fix quotes on ios_ping test (ansible#32131)
491f1c8 
(cherry picked from commit ca115b0)
@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2017

@trishnaguha Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2017

cc @kedarX @privateip @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Oct 30, 2017
@rcarrillocruz @trishnaguha
Fix lookup source tests on ios_system (ansible#32254)
c24e17d 
In IOS-XE, you need to pass an interface to lookup-source, otherwise
it fails with bad syntax.
(cherry picked from commit 4b35793)
@rcarrillocruz @trishnaguha
Remove ip nameservers on ios_system/set_name_servers teardown (ansibl…
6857f6f 
…e#32239)

Not sure why lookup source-interface, the only thing tested on that
file is adding/removing name servers, no lookup is set.
(cherry picked from commit 9752ce3)
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 30, 2017
rcarrillocruz and others added 2 commits October 30, 2017 19:13
@rcarrillocruz @trishnaguha
fix conflict
0f6c83f
@trishnaguha
Update CHANGELOG
275c2e4 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha added networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 30, 2017
@trishnaguha trishnaguha merged commit 262d6b6 into ansible:stable-2.4 Oct 30, 2017
@trishnaguha trishnaguha deleted the stable-2.4 branch October 30, 2017 13:47
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. cisco Cisco technologies ios Cisco IOS community networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trishnaguha @ansibot @dagwieers @bcoca @rcarrillocruz