Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snmp bugs on Nexus 3500 platform #32773

Merged
merged 3 commits into from
Nov 13, 2017
Merged

Fix snmp bugs on Nexus 3500 platform #32773

merged 3 commits into from
Nov 13, 2017

Conversation

mikewiebe
Copy link
Contributor

SUMMARY

This update addresses the following:

  • Modifies regexp in nxos_snmp_location module to support multiple nxos platforms
  • Detect and use different structured output keys for different nxos platforms in nxos_snmp_user module.
  • Add integration tests for nxos_snmp_location module.

NOTE: This needs to be cherry-picked into 2.4.2

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_snmp_location
nxos_snmp_user

ANSIBLE VERSION
ansible 2.5.0 (rel242/fix_snmp b72b8b0315) last updated 2017/11/09 18:39:25 (GMT -400)
  config file = None
  configured module search path = [u'/Users/mwiebe/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/lib/ansible
  executable location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/bin/ansible
  python version = 2.7.13 (default, Apr  4 2017, 08:47:57) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.38)]

@ansibot
Copy link
Contributor

ansibot commented Nov 9, 2017

cc @GGabriele @jedelman8 @kedarX @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Nov 9, 2017
@trishnaguha trishnaguha self-assigned this Nov 10, 2017
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Nov 10, 2017
@gundalow
Copy link
Contributor

NOTE: This needs to be cherry-picked into 2.4.2

@gundalow gundalow added this to the 2.4.0 milestone Nov 10, 2017
@trishnaguha trishnaguha added this to Blocker in 2.4.x Blocker List Nov 13, 2017
@trishnaguha trishnaguha moved this from Blocker to Nice to have in 2.4.x Blocker List Nov 13, 2017
@trishnaguha
Copy link
Member

needs_contributor

@ansibot ansibot added the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Nov 13, 2017
@trishnaguha trishnaguha merged commit de8d00b into ansible:devel Nov 13, 2017
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Nov 13, 2017
@mikewiebe @trishnaguha
Fix snmp bugs on Nexus 3500 platform (ansible#32773)
4f93d4f 
* Add n35 platform support

* Fix regex bug and add snmp_location it tests

* Enable nxos_snmp_location tests

(cherry picked from commit de8d00b)
@trishnaguha trishnaguha moved this from Nice to have to Done in 2.4.2 in 2.4.x Blocker List Nov 13, 2017
trishnaguha added a commit that referenced this pull request Nov 13, 2017
@trishnaguha
Fix snmp bugs on Nexus 3500 platform (#32773) (#32847)
4433544 
* Add n35 platform support

* Fix regex bug and add snmp_location it tests

* Enable nxos_snmp_location tests

(cherry picked from commit de8d00b)
@trishnaguha
Copy link
Member

cherry picked to 2.4.2

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
@sivel sivel removed the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mikewiebe @ansibot @gundalow @trishnaguha @sivel @dagwieers