forked from ansible/ansible
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix snmp bugs on Nexus 3500 platform (ansible#32773)
* Add n35 platform support * Fix regex bug and add snmp_location it tests * Enable nxos_snmp_location tests
- Loading branch information
1 parent
d970801
commit de8d00b
Showing
11 changed files
with
144 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
test/integration/targets/nxos_snmp_location/defaults/main.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--- | ||
testcase: "*" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
dependencies: | ||
- prepare_nxos_tests |
15 changes: 15 additions & 0 deletions
15
test/integration/targets/nxos_snmp_location/tasks/cli.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
- name: collect all cli test cases | ||
find: | ||
paths: "{{ role_path }}/tests/cli" | ||
patterns: "{{ testcase }}.yaml" | ||
register: test_cases | ||
|
||
- name: set test_items | ||
set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}" | ||
|
||
- name: run test case | ||
include: "{{ test_case_to_run }}" | ||
with_items: "{{ test_items }}" | ||
loop_control: | ||
loop_var: test_case_to_run |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
# Use block to ensure that both cli and nxapi tests | ||
# will run even if there are failures or errors. | ||
- block: | ||
- { include: cli.yaml, tags: ['cli'] } | ||
always: | ||
- { include: nxapi.yaml, tags: ['nxapi'] } |
28 changes: 28 additions & 0 deletions
28
test/integration/targets/nxos_snmp_location/tasks/nxapi.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
--- | ||
- name: collect all nxapi test cases | ||
find: | ||
paths: "{{ role_path }}/tests/nxapi" | ||
patterns: "{{ testcase }}.yaml" | ||
register: test_cases | ||
|
||
- name: set test_items | ||
set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}" | ||
|
||
- name: enable nxapi | ||
nxos_config: | ||
lines: | ||
- feature nxapi | ||
- nxapi http port 80 | ||
provider: "{{ cli }}" | ||
|
||
- name: run test case | ||
include: "{{ test_case_to_run }}" | ||
with_items: "{{ test_items }}" | ||
loop_control: | ||
loop_var: test_case_to_run | ||
|
||
- name: disable nxapi | ||
nxos_config: | ||
lines: | ||
- no feature nxapi | ||
provider: "{{ cli }}" |
4 changes: 4 additions & 0 deletions
4
test/integration/targets/nxos_snmp_location/tests/cli/sanity.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
- set_fact: connection="{{ cli }}" | ||
|
||
- import_tasks: "{{ role_path }}/tests/common/sanity.yaml" |
47 changes: 47 additions & 0 deletions
47
test/integration/targets/nxos_snmp_location/tests/common/sanity.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
--- | ||
- debug: msg="START TRANSPORT:{{ connection.transport }} nxos_snmp_location sanity test" | ||
|
||
- name: Setup - Remove snmp_location if configured | ||
nxos_snmp_location: &remove | ||
location: Test | ||
state: absent | ||
timeout: 60 | ||
provider: "{{ connection }}" | ||
ignore_errors: yes | ||
|
||
- block: | ||
|
||
- name: Configure snmp host | ||
nxos_snmp_location: &config | ||
location: Test | ||
state: present | ||
timeout: 60 | ||
provider: "{{ connection }}" | ||
register: result | ||
|
||
- assert: &true | ||
that: | ||
- "result.changed == true" | ||
|
||
- name: Idempotence Check | ||
nxos_snmp_location: *config | ||
register: result | ||
|
||
- assert: &false | ||
that: | ||
- "result.changed == false" | ||
|
||
always: | ||
- name: Cleanup | ||
nxos_snmp_location: *remove | ||
register: result | ||
|
||
- assert: *true | ||
|
||
- name: Cleanup Idempotence | ||
nxos_snmp_location: *remove | ||
register: result | ||
|
||
- assert: *false | ||
|
||
- debug: msg="END TRANSPORT:{{ connection.transport }} nxos_snmp_location sanity test" |
4 changes: 4 additions & 0 deletions
4
test/integration/targets/nxos_snmp_location/tests/nxapi/sanity.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
- set_fact: connection="{{ nxapi }}" | ||
|
||
- import_tasks: "{{ role_path }}/tests/common/sanity.yaml" |