Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "YAML inventory unit test: fix test inventory format (#33828)" #33869

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

gundalow
Copy link
Contributor

SUMMARY

This reverts commit dfb2f34.

As yaml plugin should not be responsible for ungrouped

Original PR #33828

ISSUE TYPE
  • Bugfix Pull Request

@gundalow
Copy link
Contributor Author

rebuild_merge

@gundalow
Copy link
Contributor Author

@pilou- FYI

@pilou-
Copy link
Contributor

pilou- commented Dec 13, 2017

Then it should be inventory plugin should not be responsible for ungrouped. But there isn't such rule: for example ini, advanced_host_list and host_list handle ungrouped group.

Meanwhile this fix doesn't broke anything, could we keep this fix waiting for a more global inventory plugin should not be responsible for ungrouped fix ?

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Dec 13, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Dec 13, 2017
@bcoca
Copy link
Member

bcoca commented Dec 13, 2017

correct fix in #33878

@ansibot ansibot merged commit cfb15b0 into ansible:devel Dec 13, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants