Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reconcile to ensure 'ungrouped' #33878

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Dec 13, 2017

SUMMARY

also removed redundant 'hosts to all' as all groups already ensure that inheritance
fixes #33877

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION
2.5/2.4

also removed redundant 'hosts to all' as all groups already ensure that inheritance
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request inventory Inventory category needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 13, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Dec 13, 2017
@bcoca bcoca added this to Blocker in 2.4.x Blocker List Dec 13, 2017
@pilou-
Copy link
Contributor

pilou- commented Dec 13, 2017

With this commit, results of commands listed in the issue are those expected.

shipit

@bcoca bcoca merged commit ad94a3a into ansible:devel Dec 13, 2017
pilou- added a commit to pilou-/ansible that referenced this pull request Dec 14, 2017
@bcoca bcoca deleted the fix_inv_reconcile branch December 19, 2017 20:01
@bcoca bcoca moved this from Blocker to Done in 2.4.3 in 2.4.x Blocker List Dec 19, 2017
albertomurillo pushed a commit to albertomurillo/ansible that referenced this pull request Dec 20, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
pilou- added a commit to peopledoc/ansible-boot-docker that referenced this pull request Jun 20, 2018
'groups' parameter was required for Ansible <= 2.4.2 in order to workaround
ansible/ansible#33878. This parameter is now useless.

Closes #5
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. inventory Inventory category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
Development

Successfully merging this pull request may close these issues.

YAML inventory: ungrouped group isn't populated
3 participants