Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the azure storage version #34442

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Jan 4, 2018

SUMMARY

The azure-mgmt-storage version is upgrade, but the azure module uses the latest model version to call the old API version, results in the DeserializationError:

/tmp/ansible_frHOyW/ansible_module_azure_rm_storageaccount.py", line 416, in create_account
    poller = self.storage_client.storage_accounts.create(self.resource_group, self.name, parameters)
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/azure/mgmt/storage/v2017_06_01/operations/storage_accounts_operations.py", line 159, in create
    body_content = self._serialize.body(parameters, 'StorageAccountCreateParameters')
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/msrest/serialization.py", line 460, in body
    SerializationError, "Unable to build a model: "+str(err), err)
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/msrest/exceptions.py", line 48, in raise_with_traceback
    raise error
msrest.exceptions.SerializationError: Unable to build a model: <SkuName.standard_lrs: 'Standard_LRS'> is not valid value for enum <enum 'SkuName'>, DeserializationError: <SkuName.standard_lrs: 'Standard_LRS'> is not valid value for enum <enum 'SkuName'>
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm

ANSIBLE VERSION
2.4

azure_mgmt_storage-1.5.0

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jan 4, 2018

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 azure bugfix_pull_request cloud needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 4, 2018
@yuwzho
Copy link
Contributor Author

yuwzho commented Jan 4, 2018

A quick fix for the #33897 , since this is block the user create storage account, also block the virtual machine created.

For pining SDK model/API version, we need feather fix for all the azure components.

@nitzmahone nitzmahone merged commit 6d3fafa into ansible:devel Jan 4, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jan 5, 2018
nitzmahone added a commit that referenced this pull request Jan 10, 2018
@nitzmahone
Copy link
Member

cherry-picked to stable-2.4 for 2.4.3rc1

yuwzho added a commit to VSChina/ansible that referenced this pull request Jan 15, 2018
yuwzho added a commit to VSChina/ansible that referenced this pull request Jan 15, 2018
@yuwzho yuwzho deleted the yuwzho-storage branch February 1, 2018 12:06
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 azure bug This issue/PR relates to a bug. cloud support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants