Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for awsvpc on ecs_taskdefinition module and ecs_service #34369

Closed
wants to merge 1 commit into from
Closed

Add support for awsvpc on ecs_taskdefinition module and ecs_service #34369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/ansible/modules/cloud/amazon/ecs_service.py
View file
Open in desktop
Expand Up @@ -322,7 +322,7 @@ def is_matching_service(self, expected, existing):

def create_service(self, service_name, cluster_name, task_definition, load_balancers,
desired_count, client_token, role, deployment_configuration,
placement_constraints, placement_strategy):
placement_constraints, placement_strategy, network_configuration):
response = self.ecs.create_service(
cluster=cluster_name,
serviceName=service_name,
Expand All @@ -333,7 +333,8 @@ def create_service(self, service_name, cluster_name, task_definition, load_balan
role=role,
deploymentConfiguration=deployment_configuration,
placementConstraints=placement_constraints,
placementStrategy=placement_strategy)
placementStrategy=placement_strategy,
networkConfiguration=network_configuration)
return self.jsonize(response['service'])

def update_service(self, service_name, cluster_name, task_definition,
Expand Down Expand Up @@ -380,7 +381,8 @@ def main():
repeat=dict(required=False, type='int', default=10),
deployment_configuration=dict(required=False, default={}, type='dict'),
placement_constraints=dict(required=False, default=[], type='list'),
placement_strategy=dict(required=False, default=[], type='list')
placement_strategy=dict(required=False, default=[], type='list'),
network_configuration=dict(required=False, default=[], type='dict')
))

module = AnsibleModule(argument_spec=argument_spec,
Expand Down Expand Up @@ -449,7 +451,8 @@ def main():
role,
deploymentConfiguration,
module.params['placement_constraints'],
module.params['placement_strategy'])
module.params['placement_strategy'],
module.params['network_configuration'])

results['service'] = response

Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py
View file
Open in desktop
Expand Up @@ -216,7 +216,7 @@ def main():
family=dict(required=False, type='str'),
revision=dict(required=False, type='int'),
containers=dict(required=False, type='list'),
network_mode=dict(required=False, default='bridge', choices=['bridge', 'host', 'none'], type='str'),
network_mode=dict(required=False, default='bridge', choices=['bridge', 'host', 'awsvpc', 'none'], type='str'),
task_role_arn=dict(required=False, default='', type='str'),
volumes=dict(required=False, type='list')))

Expand Down