Azure rm routetable #34710

tomvachon · 2018-01-10T19:00:16Z

SUMMARY

Azure Route Table Module

Module does not exist at this time and is needed

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

azure_rm_routetable

ANSIBLE VERSION

ansible 2.3.1.0
  config file =
  configured module search path = Default w/o overrides
  python version = 2.7.14 (default, Jan  6 2018, 12:16:16) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

ADDITIONAL INFORMATION

The Ansible Azure modules have incredible difficulty running on 2.4 or higher (even most issues on 2.3 are around libraries). They do need a complete re-look for those reason and this is why I developed on 2.3 (but it shouldn't be 2.3 specific code)

ansibot · 2018-01-10T19:01:09Z

cc @haroldwongms @nitzmahone @tstringer @xscript @yuwzho @zikalino
click here for bot help

mattclay · 2018-01-10T20:45:35Z

lib/ansible/modules/cloud/azure/azure_rm_routetable.py

+DOCUMENTATION = '''
+---
+module: azure_rm_routetable
+version_added: ""


This should be: version_added: "2.5"

Matt, I would but the entire Azure setup doesnt run on 2.5 (the CI tests seem to though, so maybe its good enough?). Its complaining about the azure python module. If you have a 2.5 requirements.txt which you know works, I'd be happy to update and test. I was making integration tests now.

ansibot · 2018-01-10T20:47:43Z

click here for bot help

tomvachon · 2018-01-11T16:30:42Z

This is going to fail Shippable because its out of VM quota. Nothing to do with my change...

"msg": "Error creating or updating virtual machine testvm002 - Azure Error: OperationNotAllowed\nMessage: Operation results in exceeding quota limits of Core. Maximum allowed: 10, Current in use: 10, Additional requested: 1. Please read more about quota increase at http://aka.ms/corequotaincrease."

mattclay · 2018-01-11T17:18:46Z

docs/docsite/rst/module_docs/azure_rm_routetable_module.rst

@@ -0,0 +1,459 @@
+.. _azure_rm_routetable:


This file shouldn't be part of the PR. It is generated when we build our docs.

Removed with newest commit

ansibot · 2018-01-19T21:02:22Z

cc @trstringer
click here for bot help

tomvachon · 2018-02-08T16:31:42Z

Can someone please look at this for 2.5 inclusion?

zikalino · 2018-02-09T01:29:24Z

lib/ansible/module_utils/azure_rm_common.py

@@ -75,6 +75,8 @@
 CIDR_PATTERN = re.compile(r"(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1"
                          r"[0-9]{2}|2[0-4][0-9]|25[0-5])(/([0-9]|[1-2][0-9]|3[0-2]))")

+NEXT_HOP_TYPE = ['VirtualNetworkGateway', 'VnetLocal', 'Internet', 'VirtualAppliance']


@tomvachon you could move this change to azure_rm_routetable module.
if you don't make changes in common code CI is much faster and simpler, as only your module is tested, and you will also avoid any conflicts with other prs

zikalino · 2018-02-09T01:33:07Z

@tomvachon i will review this module soon, but i can't merge it myself.
also i think right now it will be too late to merge it into 2.5.
in a meanwhile would you be interested in including it in Azure Preview Modules here: https://galaxy.ansible.com/Azure/azure_preview_modules/ ?

Fred-sun · 2018-08-10T08:22:28Z

@tomvachon Do you agree with @zikalino? Could you please help update the PR? Thanks!

tomvachon · 2018-08-10T12:22:36Z

@Fred-sun done, sorry i didnt see that comment

ansibot · 2018-08-10T13:11:15Z

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/azure_rm_routetable/aliases:0:0: missing alias `shippable/azure/group[1-4]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_routetable.py:348:1: E305 expected 2 blank lines after class or function definition, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_routetable.py:0:0: E307 version_added should be 2.7. Currently 2.5
lib/ansible/modules/cloud/azure/azure_rm_routetable.py:0:0: E322 "purge" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_routetable.py:0:0: E324 Value for "default" from the argument_spec (None) for "location" does not match the documentation ('resource_group location')
lib/ansible/modules/cloud/azure/azure_rm_routetable.py:0:0: E325 argument_spec for "purge_routes" defines type="bool" but documentation does not

click here for bot help

Fred-sun · 2018-08-13T07:51:49Z

@zikalino @mattclay Could you help review this PR? Thanks!

Fred-sun · 2018-08-16T09:09:20Z

@zikalino @mattclay Could you help review this PR? Thanks!

Fred-sun · 2018-08-17T06:40:21Z

@zikalino @mattclay Could you help review this PR? Thanks!

Fred-sun · 2018-08-21T07:50:52Z

@zikalino @mattclay Could you help review this PR? Thanks!

Fred-sun · 2018-08-24T01:59:10Z

@tomvachon Thanks for the contribution, Could you help to resolve the conflicting？ Thanks!

yuwzho · 2018-08-24T02:24:13Z

duplicate_of #41175

tomvachon added 2 commits January 9, 2018 14:24

Initial work to include azure route tables

937b6f0

Completed and tested Route Table Module

ac06d02

Unit tests

bf8919f

mattclay reviewed Jan 10, 2018

View reviewed changes

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Jan 10, 2018

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jan 10, 2018

Add Unit tests, updates to documentation

b44cdf6

ansibot added test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. labels Jan 11, 2018

Resolve missed Pylint and PEP8 failures

040034d

mattclay reviewed Jan 11, 2018

View reviewed changes

Remove doc

67bdb38

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 11, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 19, 2018

ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 27, 2018

zikalino reviewed Feb 9, 2018

View reviewed changes

ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 1, 2018

ansibleazurebot mentioned this pull request Mar 7, 2018

Azure rm routetable VSChina/ansible-issue-tracker#80

Closed

joakimhellum mentioned this pull request Jul 7, 2018

including modules that have not yet been merged in ansible into azure preview modules Azure/azure_preview_modules#99

Closed

Move constant per PR

681e792

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 10, 2018

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 10, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2018

ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed new_module This PR includes a new module. labels Aug 24, 2018

ansibot closed this Aug 24, 2018

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure rm routetable #34710

Azure rm routetable #34710

tomvachon commented Jan 10, 2018

ansibot commented Jan 10, 2018

mattclay Jan 10, 2018

tomvachon Jan 11, 2018 •

edited

ansibot commented Jan 10, 2018

tomvachon commented Jan 11, 2018

mattclay Jan 11, 2018

tomvachon Jan 11, 2018

ansibot commented Jan 19, 2018

tomvachon commented Feb 8, 2018

zikalino Feb 9, 2018

zikalino commented Feb 9, 2018

Fred-sun commented Aug 10, 2018

tomvachon commented Aug 10, 2018

ansibot commented Aug 10, 2018

Fred-sun commented Aug 13, 2018

Fred-sun commented Aug 16, 2018

Fred-sun commented Aug 17, 2018

Fred-sun commented Aug 21, 2018

Fred-sun commented Aug 24, 2018

yuwzho commented Aug 24, 2018

Azure rm routetable #34710

Azure rm routetable #34710

Conversation

tomvachon commented Jan 10, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Jan 10, 2018

mattclay Jan 10, 2018

Choose a reason for hiding this comment

tomvachon Jan 11, 2018 • edited

Choose a reason for hiding this comment

ansibot commented Jan 10, 2018

tomvachon commented Jan 11, 2018

mattclay Jan 11, 2018

Choose a reason for hiding this comment

tomvachon Jan 11, 2018

Choose a reason for hiding this comment

ansibot commented Jan 19, 2018

tomvachon commented Feb 8, 2018

zikalino Feb 9, 2018

Choose a reason for hiding this comment

zikalino commented Feb 9, 2018

Fred-sun commented Aug 10, 2018

tomvachon commented Aug 10, 2018

ansibot commented Aug 10, 2018

Fred-sun commented Aug 13, 2018

Fred-sun commented Aug 16, 2018

Fred-sun commented Aug 17, 2018

Fred-sun commented Aug 21, 2018

Fred-sun commented Aug 24, 2018

yuwzho commented Aug 24, 2018

tomvachon Jan 11, 2018 •

edited