-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure rm routetable #34710
Azure rm routetable #34710
Conversation
DOCUMENTATION = ''' | ||
--- | ||
module: azure_rm_routetable | ||
version_added: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be: version_added: "2.5"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matt, I would but the entire Azure setup doesnt run on 2.5 (the CI tests seem to though, so maybe its good enough?). Its complaining about the azure python module. If you have a 2.5 requirements.txt which you know works, I'd be happy to update and test. I was making integration tests now.
This is going to fail Shippable because its out of VM quota. Nothing to do with my change... "msg": "Error creating or updating virtual machine testvm002 - Azure Error: OperationNotAllowed\nMessage: Operation results in exceeding quota limits of Core. Maximum allowed: 10, Current in use: 10, Additional requested: 1. Please read more about quota increase at http://aka.ms/corequotaincrease." |
@@ -0,0 +1,459 @@ | |||
.. _azure_rm_routetable: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be part of the PR. It is generated when we build our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed with newest commit
Can someone please look at this for 2.5 inclusion? |
@@ -75,6 +75,8 @@ | |||
CIDR_PATTERN = re.compile(r"(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1" | |||
r"[0-9]{2}|2[0-4][0-9]|25[0-5])(/([0-9]|[1-2][0-9]|3[0-2]))") | |||
|
|||
NEXT_HOP_TYPE = ['VirtualNetworkGateway', 'VnetLocal', 'Internet', 'VirtualAppliance'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomvachon you could move this change to azure_rm_routetable module.
if you don't make changes in common code CI is much faster and simpler, as only your module is tested, and you will also avoid any conflicts with other prs
@tomvachon i will review this module soon, but i can't merge it myself. |
@tomvachon Do you agree with @zikalino? Could you please help update the PR? Thanks! |
@Fred-sun done, sorry i didnt see that comment |
The test
The test
The test
|
3 similar comments
@tomvachon Thanks for the contribution, Could you help to resolve the conflicting? Thanks! |
duplicate_of #41175 |
SUMMARY
Azure Route Table Module
Module does not exist at this time and is needed
ISSUE TYPE
COMPONENT NAME
azure_rm_routetable
ANSIBLE VERSION
ADDITIONAL INFORMATION
The Ansible Azure modules have incredible difficulty running on 2.4 or higher (even most issues on 2.3 are around libraries). They do need a complete re-look for those reason and this is why I developed on 2.3 (but it shouldn't be 2.3 specific code)