Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mellanox OS name change: MLNXOS changed to ONYX #34753

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Mellanox OS name change: MLNXOS changed to ONYX #34753

merged 2 commits into from
Jan 11, 2018

Conversation

samerd
Copy link
Contributor

@samerd samerd commented Jan 11, 2018

Signed-off-by: Samer Deeb samerd@mellanox.com

SUMMARY

Mellanox OS name was changed from MLNX-OS to ONYX
All module names and documents were changed accordingly

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/network/onyx

ANSIBLE VERSION
ansible 2.5.0 (feature/onyx 6c8307255e) last updated 2018/01/11 19:40:03 (GMT +000)
  config file = /etc/ansible/ansible.cfg
  python version = 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]
ADDITIONAL INFORMATION

@samerd
Mellanox OS name change: MLNXOS changed to ONYX
6c83072 
Signed-off-by: Samer Deeb <samerd@mellanox.com>
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 feature_pull_request needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Jan 11, 2018
@gundalow gundalow self-assigned this Jan 11, 2018
@gundalow gundalow added this to the 2.5.0 milestone Jan 11, 2018
gundalow
gundalow requested changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor thing

docs/docsite/rst/dev_guide/developing_module_utilities.rst Outdated
@@ -48,7 +48,7 @@ The following is a list of module_utils files and a general description. The mod
- network/iosxr/iosxr.py - Definitions and helper functions for modules that manage Cisco IOS-XR networking devices.
- network/ironware/ironware.py - Module support utilities for managing Brocade IronWare devices.
- network/junos/junos.py - Definitions and helper functions for modules that manage Junos networking devices.
- network/mlnxos/mlnxos.py - Definitions and helper functions for modules that manage Mellanox MLNX-OS networking devices.
- network/onyx/onyx.py - Definitions and helper functions for modules that manage Mellanox ONYX networking devices.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetic order pleae

@gundalow
Copy link
Contributor

bot_status

@gundalow gundalow mentioned this pull request Jan 11, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jan 11, 2018

Components

Metadata

waiting_on: samerd
changes_requested_by: gundalow
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:

click here for bot help

@samerd
Fix alphabetical order of modules metadata
23f74ae 
Signed-off-by: Samer Deeb <samerd@mellanox.com>
@gundalow
Copy link
Contributor

rebuild_merge

@gundalow gundalow merged commit f8884f1 into ansible:devel Jan 11, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jan 19, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@samerd samerd deleted the feature/onyx branch August 22, 2018 19:39
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees

@gundalow gundalow

Labels
affects_2.5 This issue/PR affects Ansible v2.5 feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@samerd @gundalow @ansibot @s-hertel