Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aci_aaa_user_certificate: Rename user parameter to aaa_user #35207

Merged
merged 1 commit into from
Jan 23, 2018
Merged

aci_aaa_user_certificate: Rename user parameter to aaa_user #35207

merged 1 commit into from
Jan 23, 2018

Conversation

dagwieers
Copy link
Contributor

SUMMARY

Since user is an alias for username as well as the name of the user to manage, we need to make a clearer distinction. (Fortunately this conflict did work out fine, but it's better to avoid it).

So this PR removes any confusion.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aci_aaa_user_certificate

ANSIBLE VERSION

v2.5

@dagwieers dagwieers added the aci Cisco ACI community label Jan 23, 2018
@dagwieers dagwieers added this to the 2.5.0 milestone Jan 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2018

cc @brunocalogero @jmcgill298 @schunduri
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jan 23, 2018
@dagwieers dagwieers merged commit 64df1a7 into ansible:devel Jan 23, 2018
Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@dagwieers @Lujeni
aci_aaa_user_certificate: Rename user parameter to aaa_user (ansible#…
b1487b4 
…35207)
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dagwieers @ansibot