-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creates new structure for network docs #35514
Conversation
@dharmabumstead since this PR removes the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor thing
@@ -0,0 +1,15 @@ | |||
Ansible Network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
***************
Ansible Network
***************
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current docs have inconsistent header styling (it has probably accumulated through the years). I'd prefer to discuss this, come up with a consistent notation, and submit one PR that makes all the docs use the same notation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #35520 to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Ignore this comment and we can address this in the bulk fix up PR.
As long as Shippable RST check passes (which it is) I'm happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! Nicely done, @acozine!
SUMMARY
Creates a bare-bones landing page for the network docs at the top level of the documentation. This structural change will allow future work on network docs to move ahead more independently.
ISSUE TYPE
COMPONENT NAME
Network documentation
ANSIBLE VERSION
ADDITIONAL INFORMATION
See https://docs.google.com/document/d/1JzmxJn6DUPgQ-tjpgEqq-pjtTb4LbhRQicpBM28lCdI for the bigger picture.