Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error option name and invalid option. #36579

Closed
wants to merge 3 commits into from
Closed

Conversation

fltang
Copy link

@fltang fltang commented Feb 22, 2018

SUMMARY

There's no option named "merge_multiple_cli_flags", so modify it to "merge_multiple_cli_tags".

The config option "system_warnings" is unavailable as the function system_warning() in "/lib/ansible/utils/display.py" has never been used anywhere. So reverse the relationship of
"warning()" and "system_warning()" to make option "system_warnings" available.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

examples/ansible.cfg
/lib/ansible/utils/display.py

ANSIBLE VERSION
2.6.0 0.0.devel
ADDITIONAL INFORMATION

@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 22, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 26, 2018
@fltang fltang changed the title Fix error option name. Fix error option name and invalid option. Feb 27, 2018
warning() should have the same argument as before.
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 2, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 10, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 21, 2018
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Oct 24, 2018
@s-hertel
Copy link
Contributor

Hi @fltang. merge_multiple_cli_flags has been deprecated in 51e3390 and will be removed after 2.8, so you can remove that modification. It looks like the rest of this fixes the fact that you cannot turn off system warnings and seems correct.

@Akasurde
Copy link
Member

@fltang Are you still working on this, let us know ? Thanks, needs_info

@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Nov 23, 2019

@fltang This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Dec 25, 2019

@fltang You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help

@ansibot ansibot closed this Dec 25, 2019
@ansible ansible locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. needs_info This issue requires further information. Please answer any outstanding questions. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants