Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cliconf get_config method to match base signature #36682

Merged
merged 1 commit into from Feb 26, 2018
Merged

fix cliconf get_config method to match base signature #36682

merged 1 commit into from Feb 26, 2018

Conversation

privateip
Copy link
Contributor

This commit fixes up the get_config method to match the minimum method
signature as defined by the base class. Without this patch, the
get_config method calls will fail in some cirumstances.

fix cliconf get_config method to match base signature
e97ca37 
This commit fixes up the get_config method to match the minimum method
signature as defined by the base class.  Without this patch, the
get_config method calls will fail in some cirumstances.
@ansibot
Copy link
Contributor

ansibot commented Feb 24, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @mikewiebe @paulquack @rahushen @rcarrillocruz @samerd @trishnaguha
click here for bot help

@ansibot ansibot added needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 24, 2018
trishnaguha
trishnaguha approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@trishnaguha trishnaguha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 26, 2018
@privateip privateip merged commit fb6a8c0 into ansible:devel Feb 26, 2018
@privateip privateip deleted the fix-cliconf-get-config branch February 26, 2018 15:56
privateip added a commit that referenced this pull request Feb 26, 2018
@privateip
fix cliconf get_config method to match base signature (#36682)
b86f073 
This commit fixes up the get_config method to match the minimum method
signature as defined by the base class.  Without this patch, the
get_config method calls will fail in some cirumstances.

(cherry picked from commit fb6a8c0)
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
cisco Cisco technologies networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@privateip @ansibot @ganeshrn @trishnaguha @dagwieers