Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cliconf get_config method to match base signature #36682

Merged
merged 1 commit into from Feb 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/aireos.py
Expand Up @@ -55,7 +55,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running'):
def get_config(self, source='running', format='text'):
if source not in ('running', 'startup'):
return self.invalid_params("fetching configuration from %s is not supported" % source)
if source == 'running':
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/aruba.py
Expand Up @@ -56,7 +56,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running'):
def get_config(self, source='running', format='text'):
if source not in ('running', 'startup'):
return self.invalid_params("fetching configuration from %s is not supported" % source)
if source == 'running':
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/asa.py
Expand Up @@ -53,7 +53,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running'):
def get_config(self, source='running', format='text'):
if source not in ('running', 'startup'):
return self.invalid_params("fetching configuration from %s is not supported" % source)
if source == 'running':
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/dellos10.py
Expand Up @@ -57,7 +57,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running'):
def get_config(self, source='running', format='text'):
if source not in ('running', 'startup'):
return self.invalid_params("fetching configuration from %s is not supported" % source)
if source == 'running':
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/dellos6.py
Expand Up @@ -57,7 +57,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running'):
def get_config(self, source='running', format='text'):
if source not in ('running', 'startup'):
return self.invalid_params("fetching configuration from %s is not supported" % source)
# if source == 'running':
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/dellos9.py
Expand Up @@ -57,7 +57,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running'):
def get_config(self, source='running', format='text'):
if source not in ('running', 'startup'):
return self.invalid_params("fetching configuration from %s is not supported" % source)
# if source == 'running':
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/edgeos.py
Expand Up @@ -38,7 +38,7 @@ def get_device_info(self):

return device_info

def get_config(self):
def get_config(self, source='running', format='text'):
return self.send_command(b'show configuration commands')

def edit_config(self, command):
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/enos.py
Expand Up @@ -58,7 +58,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running'):
def get_config(self, source='running', format='text'):
if source not in ('running', 'startup'):
msg = "fetching configuration from %s is not supported"
return self.invalid_params(msg % source)
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/ios.py
Expand Up @@ -53,7 +53,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running', flags=None):
def get_config(self, source='running', format='text', flags=None):
if source not in ('running', 'startup'):
return self.invalid_params("fetching configuration from %s is not supported" % source)
if source == 'running':
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/iosxr.py
Expand Up @@ -56,7 +56,7 @@ def get_device_info(self):

return device_info

def get_config(self, source='running', filter=None):
def get_config(self, source='running', format='text', filter=None):
lookup = {'running': 'running-config'}
if source not in lookup:
return self.invalid_params("fetching configuration from %s is not supported" % source)
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/ironware.py
Expand Up @@ -49,7 +49,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running', flags=None):
def get_config(self, source='running', format='text', flags=None):
if source not in ('running', 'startup'):
return self.invalid_params("fetching configuration from %s is not supported" % source)

Expand Down
5 changes: 3 additions & 2 deletions lib/ansible/plugins/cliconf/nxos.py
Expand Up @@ -50,11 +50,12 @@ def get_device_info(self):

return device_info

def get_config(self, source='running', flags=None):
def get_config(self, source='running', format='text', flags=None):
lookup = {'running': 'running-config', 'startup': 'startup-config'}

cmd = 'show {} '.format(lookup[source])
cmd += ' '.join(flags)
if flags:
cmd += ' '.join(flags)
cmd = cmd.strip()

return self.send_command(cmd)
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/onyx.py
Expand Up @@ -48,7 +48,7 @@ def get_device_info(self):
return device_info

@enable_mode
def get_config(self, source='running'):
def get_config(self, source='running', format='text'):
if source not in ('running',):
return self.invalid_params("fetching configuration from %s is not supported" % source)
cmd = b'show running-config'
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/plugins/cliconf/vyos.py
Expand Up @@ -51,7 +51,7 @@ def get_device_info(self):

return device_info

def get_config(self):
def get_config(self, source='running', format='text'):
return self.send_command(b'show configuration commands')

def edit_config(self, command):
Expand Down