[cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock - fixes #37003 #37010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
aws
bug
s-hertel
force-pushed
the
ec2_vpc_route_vpc_endpoint
branch
from
c98fa6a
to
a88bd9a
Compare
Add module warnings rather than silently skipping
|
Should there be a test for this change? It does look good to me but a test would give me greater confidence before merging. |
|
Added a test to ensure a VPC endpoint associated with a route table doesn't result in traceback (which is what happens now but not prior to 2.5) with the ec2_vpc_route_table module. It's going to need CI permissions added. |
… not result in a traceback
s-hertel
added
the
needs_ci_update
ansibot
added
test
ryansb
approved these changes
Mar 12, 2018
|
Looks good, pending CI updates. |
|
bot_status |
Componentslib/ansible/modules/cloud/amazon/ec2_vpc_route_table.py test/integration/targets/ec2_vpc_route_table/tasks/main.yml Metadatawaiting_on: ansible |
ansibot
added
committer_review
s-hertel
removed
the
needs_ci_update
|
This is definitely a backport contender. I'll cherry-pick |
willthames
pushed a commit
to willthames/ansible
that referenced
this pull request
Apr 24, 2018
…ck - fixes ansible#37003 (ansible#37010) * [cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock Add module warnings rather than silently skipping * Permit warnings for routes tables containing vpc endpoints to be turned off * Add tests to ensure a VPC endpoint associated with a route table does not result in a traceback (cherry picked from commit da3f7a8)
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Apr 27, 2018
…ck - fixes ansible#37003 (ansible#37010) * [cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock Add module warnings rather than silently skipping * Permit warnings for routes tables containing vpc endpoints to be turned off * Add tests to ensure a VPC endpoint associated with a route table does not result in a traceback
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Apr 27, 2018
…ck - fixes ansible#37003 (ansible#37010) * [cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock Add module warnings rather than silently skipping * Permit warnings for routes tables containing vpc endpoints to be turned off * Add tests to ensure a VPC endpoint associated with a route table does not result in a traceback (cherry picked from commit 246ff9c)
ryansb
pushed a commit
that referenced
this pull request
Apr 27, 2018
…ck - fixes #37003 (#37010) (#39210) * [cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock Add module warnings rather than silently skipping * Permit warnings for routes tables containing vpc endpoints to be turned off * Add tests to ensure a VPC endpoint associated with a route table does not result in a traceback (cherry picked from commit da3f7a8)
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Apr 30, 2018
s-hertel
added a commit
that referenced
this pull request
Apr 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #37003. Regression introduced when porting the module from boto to boto3.
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/amazon/ec2_vpc_route_table.py
ANSIBLE VERSION