Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock - fixes #37003 (#37010) #39210

Merged
merged 1 commit into from Apr 27, 2018
Merged

[cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock - fixes #37003 (#37010) #39210

merged 1 commit into from Apr 27, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY
  • [cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock

Add module warnings rather than silently skipping

  • Permit warnings for routes tables containing vpc endpoints to be turned off

  • Add tests to ensure a VPC endpoint associated with a route table does not result in a traceback

(cherry picked from commit da3f7a8)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vpc_route_table

ANSIBLE VERSION
2.5.1
ADDITIONAL INFORMATION

Please don't squash and merge (this protects the original commit authorship)

@s-hertel
[cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlo…
0d0b944 
…ck - fixes ansible#37003 (ansible#37010)

* [cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock

Add module warnings rather than silently skipping

* Permit warnings for routes tables containing vpc endpoints to be turned off

* Add tests to ensure a VPC endpoint associated with a route table does not result in a traceback

(cherry picked from commit da3f7a8)
@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2018

cc @wimnat
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Apr 24, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Apr 24, 2018
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 27, 2018
@ryansb ryansb merged commit b9df2e5 into ansible:stable-2.5 Apr 27, 2018
@s-hertel s-hertel mentioned this pull request Apr 30, 2018
Merged
@willthames willthames mentioned this pull request May 9, 2018
Closed
@ansible ansible locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. support:certified This issue/PR relates to certified code. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@willthames @ansibot @ryansb @webknjaz @s-hertel