Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powershell: display non-ascii characters in command outputs #37229

Merged
merged 1 commit into from Apr 5, 2018
Merged

powershell: display non-ascii characters in command outputs #37229

merged 1 commit into from Apr 5, 2018

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Mar 9, 2018 •
edited

SUMMARY

Fixed up CommandUtil, Become and Async to properly display non ascii characters as it does not inherit the WinRM console settings. It also removed some compilation warnings for CommandUtil with the fixes required.

Fixes #33127

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_command
win_shell
become
async

ANSIBLE VERSION
2.5

@jborean93 jborean93 mentioned this pull request Mar 9, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Mar 9, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 9, 2018
@jborean93 jborean93 added this to To Do in 2.5.x blocker list via automation Mar 9, 2018
@jborean93 jborean93 moved this from To Do to 2.5.1 Holding in 2.5.x blocker list Mar 9, 2018
@ansible ansible deleted a comment from ansibot Mar 9, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 9, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Mar 9, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 17, 2018
dagwieers
dagwieers approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine (#33127 (comment))

@nitzmahone nitzmahone merged commit 71e8527 into ansible:devel Apr 5, 2018
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 5, 2018
@jborean93
powershell: display non-ascii characters in command outputs (ansible#…
dd0e914 
…37229)

(cherry picked from commit 71e8527)
@jborean93 jborean93 deleted the win_non-ascii branch April 5, 2018 22:09
@jborean93 jborean93 mentioned this pull request Apr 5, 2018
Merged
@jborean93
Copy link
Contributor Author

Backport PR to stable-2.5 #38365

jborean93 added a commit that referenced this pull request Apr 9, 2018
@jborean93
powershell: 2.5 backport display non-ascii characters in command outp…
38a13f4 
…uts (#38365)

* powershell: display non-ascii characters in command outputs (#37229)

(cherry picked from commit 71e8527)

* Added changelog fragment
@nitzmahone nitzmahone moved this from 2.5.1 Holding to 2.5.2 holding in 2.5.x blocker list Apr 18, 2018
@nitzmahone nitzmahone moved this from 2.5.2 holding to Done in 2.5.x blocker list May 30, 2018
@jborean93 jborean93 mentioned this pull request Sep 8, 2018
Closed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@jborean93 @ilicmilan
powershell: display non-ascii characters in command outputs (ansible#…
937247a 
…37229)
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems displaying German umlauts
5 participants
@jborean93 @ansibot @dagwieers @nitzmahone @s-hertel