Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powershell: 2.5 backport display non-ascii characters in command outputs #38365

Merged
merged 2 commits into from Apr 9, 2018
Merged

powershell: 2.5 backport display non-ascii characters in command outputs #38365

merged 2 commits into from Apr 9, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

When using become or anything that uses Ansible.ModuleUtils.CommandUtil (win_shell, win_command) then any non ASCII characters would not be returned correctly. This fixes that issue.

Backport of #37229

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

powershell.py

ANSIBLE VERSION
2.5

@jborean93 jborean93 changed the base branch from devel to stable-2.5 April 5, 2018 22:10
@jborean93 jborean93 closed this Apr 5, 2018
@jborean93 jborean93 reopened this Apr 5, 2018
@jborean93 jborean93 mentioned this pull request Apr 5, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Apr 5, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Apr 5, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2018
@jborean93 jborean93 merged commit 38a13f4 into ansible:stable-2.5 Apr 9, 2018
@jborean93 jborean93 deleted the win_non-ascii-2.5 branch April 9, 2018 19:25
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @mkrizek