-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #26760 - Added ability to create Openstack users without password #37338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
This issue/PR relates to a bug.
cloud
community_review
In order to be merged, this PR must follow the community review workflow.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
new_contributor
This PR is the first contribution by a new community member.
openstack
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Mar 13, 2018
ryansb
removed
the
needs_triage
Needs a first human triage before being processed.
label
Mar 13, 2018
@bingoarun this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibot
added
merge_commit
This PR contains at least one merge commit. Please resolve!
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
labels
Mar 20, 2018
The test
|
ansibot
added
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Mar 20, 2018
bingoarun
force-pushed
the
bugfix_26760_os_user
branch
from
March 20, 2018 11:51
e7a730e
to
d2fc633
Compare
ansibot
added
community_review
In order to be merged, this PR must follow the community review workflow.
and removed
ci_verified
Changes made in this PR are causing tests to fail.
merge_commit
This PR contains at least one merge commit. Please resolve!
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Mar 20, 2018
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Mar 28, 2018
emonty
approved these changes
May 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
ansibot
removed
community_review
In order to be merged, this PR must follow the community review workflow.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Sep 15, 2018
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Sep 15, 2018
ansibot
added
community_review
In order to be merged, this PR must follow the community review workflow.
support:community
This issue/PR relates to code supported by the Ansible community.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Oct 9, 2018
@bingoarun: thank you for submitting this pull-request! |
shipit |
ansibot
added
shipit
This PR is ready to be merged by Core
automerge
This PR was automatically merged by ansibot.
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Oct 13, 2018
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.6
This issue/PR affects Ansible v2.6
automerge
This PR was automatically merged by ansibot.
bug
This issue/PR relates to a bug.
cloud
module
This issue/PR relates to a module.
new_contributor
This PR is the first contribution by a new community member.
openstack
shipit
This PR is ready to be merged by Core
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #26760 - Added ability to create Openstack users without a password
Currently, openstack users can't be created without specifying the password. Openstack command line allows doing this as there is a requirement to create users with external auth like LDAP and SAML.
ISSUE TYPE
COMPONENT NAME
ansible/lib/ansible/modules/cloud/openstack/os_user.py
ANSIBLE VERSION
ADDITIONAL INFORMATION
Before change
After change