Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added module for User Account #37347

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Added module for User Account #37347

merged 1 commit into from
Mar 20, 2018

Conversation

chaitanyaavi
Copy link
Contributor

@chaitanyaavi chaitanyaavi commented Mar 13, 2018 •
edited
Loading

SUMMARY

Added module for User Account

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

network/avi/vi_useraccount.py

ANSIBLE VERSION
ansible 2.6.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/vinay/git/avitest/local/lib/python2.7/site-packages/ansible
  executable location = /home/vinay/git/avitest/bin/ansible
  python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

@ericsysmin @grastogi23 @khaltore

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

cc @ericsysmin @grastogi23 @khaltore
click here for bot help

@ansibot ansibot added avi community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 13, 2018
@grastogi23
Copy link
Contributor

@chaitanyaavi pl. update the component name and re-test with the ansible devel.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 13, 2018
gundalow
gundalow reviewed Mar 16, 2018
View reviewed changes
lib/ansible/modules/network/avi/avi_useraccount.py
version_added: 2.6
requirements: [ avisdk ]
options:
old_password:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't clear to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

username and password are part of common argument spec so to update a password user has to provide new and old both passwords. Using the password field in common argument spec user will specify the new password and with the option old_password user will specify old password or default password (Avi controller image is shipped with a default password can be used once only to update the password to bootstrap)

@grastogi23
Copy link
Contributor

Since, this is user password change we do need both password. Also, the module is created such that it can be idempotent and it allows user to not pass old_password all the time.

@grastogi23
Copy link
Contributor

+shipit

@gundalow gundalow merged commit b0a8d82 into ansible:devel Mar 20, 2018
@gundalow
Copy link
Contributor

Merged into devel will be released in Ansible 2.6.0

@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@grastogi23 grastogi23 grastogi23 approved these changes

Assignees
No one assigned
Labels
avi community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaitanyaavi @ansibot @grastogi23 @gundalow