Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_static_route issues #37614

Merged
merged 2 commits into from Mar 26, 2018
Merged

fix nxos_static_route issues #37614

merged 2 commits into from Mar 26, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Mar 19, 2018 •
edited

SUMMARY

Fixes #37612

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_static_route

ANSIBLE VERSION
ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
  • This PR fixes nxos_static_route issues #37612 and also takes care platform differences
  • Removed some dead code which was not being used
  • Enhanced test cases to test for multiple vrfs
  • Tested on all platforms and they pass

@ansibot
Copy link
Contributor

ansibot commented Mar 19, 2018

cc @GGabriele @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 19, 2018
@trishnaguha trishnaguha self-assigned this Mar 19, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Mar 19, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Mar 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 19, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:1329:1: A102 Remove since "lib/ansible/modules/network/nxos/nxos_static_route.py" passes "E324" test

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 19, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 19, 2018
trishnaguha
trishnaguha reviewed Mar 26, 2018
View reviewed changes
lib/ansible/modules/network/nxos/nxos_static_route.py
# remove ip route commands of non-default vrfs from
# the running config just in case the same commands
# exist in default and non-default vrfs
if ' ip route' not in line:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, are these whitespaces for sub command ip route when using vrf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that is correct

@trishnaguha trishnaguha merged commit 0df5cfd into ansible:devel Mar 26, 2018
@saichint saichint deleted the static_route branch March 26, 2018 15:16
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@ryancurrah
fix nxos_static_route issues (ansible#37614)
64b94ca 
* fix nxos_static_route issues

* remove nxos_static_route from ignore
@trishnaguha trishnaguha added this to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Apr 5, 2018
@trishnaguha trishnaguha moved this from Need CP into 2.5.1 to Done in zzz NOT USED: Networking Bugs Apr 6, 2018
@trishnaguha
Copy link
Member

cherry-picked to 2.5

trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Apr 6, 2018
@trishnaguha
fix nxos_static_route issues (ansible#37614)
cef5bbb 
* fix nxos_static_route issues

* remove nxos_static_route from ignore

(cherry picked from commit 0df5cfd)
trishnaguha added a commit that referenced this pull request Apr 6, 2018
@trishnaguha
stable-2.5 nxos bugfix cherry-pick (#38372)
536dff5 
* nxos_vlan purge (#38202)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 119352b)

* fix nxos_aaa_server issues (#38117)

(cherry picked from commit 697c301)

* fix nxos_aaa_server_host issues (#38188)

(cherry picked from commit 24cc6b8)

* fix nxos_static_route issues (#37614)

* fix nxos_static_route issues

* remove nxos_static_route from ignore

(cherry picked from commit 0df5cfd)

* fix nxos_acl issues (#38283)

* fix nxos_acl issues

* typo fix

* typo fix in sanity.yaml

* another typo fix in sanity.yaml

(cherry picked from commit 1bf2965)

* nxos_acl_interface tests addition (#38230)

(cherry picked from commit b8cb382)

* update changelog with nxos bugfixes for 2.5

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert ignore.txt

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_static_route issues
4 participants
@saichint @ansibot @trishnaguha @dagwieers