Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_aaa_server issues #38117

Merged
merged 1 commit into from Apr 2, 2018
Merged

fix nxos_aaa_server issues #38117

merged 1 commit into from Apr 2, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Mar 29, 2018 •
edited

SUMMARY

fixes #38115

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_aaa_server

ANSIBLE VERSION
ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
  • This PR fixes nxos_aaa_server issues #38115
  • Documentation corrections made.
  • Cleaned up dead code.
  • Integration tests enhanced for idempotence checks.
  • Tested on all platforms and they pass

@ansibot
Copy link
Contributor

ansibot commented Mar 29, 2018

cc @jedelman8 @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 29, 2018
@trishnaguha trishnaguha self-assigned this Mar 30, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Mar 30, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Mar 30, 2018
@trishnaguha trishnaguha merged commit 697c301 into ansible:devel Apr 2, 2018
@trishnaguha trishnaguha added this to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Apr 2, 2018
@saichint saichint deleted the aaa_server branch April 2, 2018 16:13
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@ryancurrah
fix nxos_aaa_server issues (ansible#38117)
b10d1c8
@trishnaguha
Copy link
Member

cherry-picked to 2.5

@trishnaguha trishnaguha moved this from Need CP into 2.5.1 to Done in zzz NOT USED: Networking Bugs Apr 6, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Apr 6, 2018
@trishnaguha
fix nxos_aaa_server issues (ansible#38117)
a8f4fbc 
(cherry picked from commit 697c301)
trishnaguha added a commit that referenced this pull request Apr 6, 2018
@trishnaguha
stable-2.5 nxos bugfix cherry-pick (#38372)
536dff5 
* nxos_vlan purge (#38202)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 119352b)

* fix nxos_aaa_server issues (#38117)

(cherry picked from commit 697c301)

* fix nxos_aaa_server_host issues (#38188)

(cherry picked from commit 24cc6b8)

* fix nxos_static_route issues (#37614)

* fix nxos_static_route issues

* remove nxos_static_route from ignore

(cherry picked from commit 0df5cfd)

* fix nxos_acl issues (#38283)

* fix nxos_acl issues

* typo fix

* typo fix in sanity.yaml

* another typo fix in sanity.yaml

(cherry picked from commit 1bf2965)

* nxos_acl_interface tests addition (#38230)

(cherry picked from commit b8cb382)

* update changelog with nxos bugfixes for 2.5

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert ignore.txt

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
fix nxos_aaa_server issues (ansible#38117)
f795075
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_aaa_server issues
4 participants
@saichint @ansibot @trishnaguha @dagwieers