Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bkprt py3 ec2 user data #37664

Merged
merged 2 commits into from
Mar 29, 2018
Merged

Bkprt py3 ec2 user data #37664

merged 2 commits into from
Mar 29, 2018

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Mar 20, 2018

SUMMARY

Fix problem with ec2 module and user_data parameter on python3

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/ec2.py

ANSIBLE VERSION
2.5.0

@abadger
Fix use of user_data field with spot_price in ec2 module (ansible#37628)
b2b30ea 
The user_data field is base64 encoded inside of the boto library.  In
Python3, base64 must be used with byte strings.  So we make sure to
encode the user_data into a byte string before passing it on to the boto
library.

Fixes ansible#34978

(cherry picked from commit 0d55081)
@abadger
Python3 ec2 fix added to changelog
3988b12
@abadger abadger added this to To Do in 2.5.x blocker list via automation Mar 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 20, 2018

cc @lwade @tgerla @willthames
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 20, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Mar 20, 2018
@abadger abadger added this to Backport tickets in Python 3 compatibility Mar 22, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 28, 2018
@nitzmahone nitzmahone merged commit 389c4d1 into ansible:stable-2.5 Mar 29, 2018
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Mar 29, 2018
@abadger abadger deleted the bkprt-py3-ec2-user_data branch March 29, 2018 22:14
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. python3 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.5.x blocker list
  
Done
Python 3 compatibility
Backport tickets
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abadger @ansibot @nitzmahone @webknjaz