Don't overwrite builtin jinja2 filters with tests #37881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
ansibot
added
test
maxamillion
approved these changes
Mar 26, 2018
sivel
removed
the
needs_triage
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Mar 26, 2018
* Don't overwrite builtin jinja2 filters with tests. Fixes ansible#37856 * Fix tests and other callers of _get_filters (cherry picked from commit 1f824bd)
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Mar 26, 2018
alikins
reviewed
Mar 26, 2018
| @@ -176,7 +176,7 @@ def generic_visit(self, node, inside_call=False, inside_yield=False): | |||
| ) | |||
| try: | |||
| e = templar.environment.overlay() | |||
| e.filters.update(templar._get_filters()) | |||
| e.filters.update(templar._get_filters(e.filters)) | |||
There was a problem hiding this comment.
could reverse the update ordering and update templar._get_filters() (or a copy...) with e.filters so that
the e.filters 'wins'
There was a problem hiding this comment.
something like
custom_filters = templar._get_filters()
custom_filters.update(e.filters)
e.filters = custom_filtersThere was a problem hiding this comment.
We may want to override a builtin filter with an ansible provided by filter, such as groupby. We just don't want this to happen with custom tests.
Eventually custom tests will no longer be registered as filters (2.9), but have been kept thus far for backwards compat.
sivel
added a commit
that referenced
this pull request
Mar 28, 2018
ryancurrah
pushed a commit
to ryancurrah/ansible
that referenced
this pull request
Apr 4, 2018
* Don't overwrite builtin jinja2 filters with tests. Fixes ansible#37856 * Fix tests and other callers of _get_filters
doubleplush
pushed a commit
to doubleplush/ansible
that referenced
this pull request
Apr 10, 2018
The abs test for absolute paths overwrites the built-in Jinja2 abs filter, preventing the absolute value of numbers from being taken and breaking existing code which makes use of the absolute value filter. Superceded by ansible#37881 in Ansible 2.6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Don't overwrite builtin jinja2 filters with tests. Fixes #37856
ISSUE TYPE
COMPONENT NAME
lib/ansible/template/init.py
ANSIBLE VERSION
ADDITIONAL INFORMATION