Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #37881 for 2.5.1 #37937

Merged
merged 2 commits into from Mar 28, 2018
Merged

Backport #37881 for 2.5.1 #37937

merged 2 commits into from Mar 28, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Mar 26, 2018

SUMMARY

Backport #37881 for 2.5.1

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/template/init.py

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

@sivel
Don't overwrite builtin jinja2 filters with tests (ansible#37881)
eff43bc 
* Don't overwrite builtin jinja2 filters with tests. Fixes ansible#37856

* Fix tests and other callers of _get_filters

(cherry picked from commit 1f824bd)
@sivel
Add changelog for ansible#37881
f0b295c
@sivel sivel requested a review from nitzmahone March 26, 2018 17:12
@sivel sivel added this to To Do in 2.5.x blocker list via automation Mar 26, 2018
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 26, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 26, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 26, 2018
@sivel sivel merged commit 6877803 into ansible:stable-2.5 Mar 28, 2018
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Apr 9, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sivel @ansibot