Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_updates: backport 2.5 handle failure on module load #38498

Merged
merged 2 commits into from Apr 9, 2018
Merged

win_updates: backport 2.5 handle failure on module load #38498

merged 2 commits into from Apr 9, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

If the win_updates action plugin fails to run the module, become doesn't work and so on. This will pick up the failure and return it back to the user instead of hiding it.

Backport of #38363

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_updates

ANSIBLE VERSION
2.5

@jborean93 jborean93 mentioned this pull request Apr 9, 2018
Merged
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 9, 2018
@jborean93
Copy link
Contributor Author

CI failures are unrelated to changes.

@jborean93 jborean93 merged commit 9bb2a36 into ansible:stable-2.5 Apr 9, 2018
@jborean93 jborean93 deleted the win_update-failure-handler-2.5 branch April 9, 2018 20:39
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Apr 10, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @webknjaz @ansibot