Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Move --list options from hardcoded to 'list' callback/strategy plugins #38403

Closed
wants to merge 16 commits into from
Closed

[WIP] Move --list options from hardcoded to 'list' callback/strategy plugins #38403

wants to merge 16 commits into from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 6, 2018 •
edited

SUMMARY

This should allow for much easier changes w/o having to change CLI code as well as 'user' customization
fixes #38176

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

list

ANSIBLE VERSION
2.6

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 6, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2018
@ansible ansible deleted a comment from ansibot Apr 9, 2018
@ansible ansible deleted a comment from ansibot Apr 9, 2018
@ansible ansible deleted a comment from ansibot Apr 9, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 18, 2018
@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 new_plugin This PR includes a new plugin. labels May 20, 2018
@bcoca bcoca mentioned this pull request May 23, 2018
Closed
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 16, 2018
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Sep 17, 2018
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 9, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 19, 2019
@ansibot
Copy link
Contributor

ansibot commented May 27, 2019

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/reference_appendices/config.rst:2025:0: duplicate-label: duplicate label list_strategy, other instance in /root/ansible/docs/docsite/rst/plugins/strategy/list.rst

click here for bot help

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 27, 2019
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 30, 2020
@bcoca bcoca mentioned this pull request Jul 30, 2020
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 7, 2020
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Aug 23, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 6, 2020
@bcoca bcoca mentioned this pull request Jan 25, 2021
Closed
@ansibot ansibot added has_issue and removed support:community This issue/PR relates to code supported by the Ansible community. labels Mar 5, 2021
@bcoca
Copy link
Member Author

bcoca commented Jun 23, 2021

closing in favor of #70995

@bcoca bcoca closed this Jun 23, 2021
@bcoca bcoca deleted the list_strat branch June 23, 2021 19:43
@ansible ansible locked and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 feature This issue/PR relates to a feature request. has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_plugin This PR includes a new plugin. pre_azp This PR was last tested before migration to Azure Pipelines. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

never tag does not show up with --list-tags
3 participants
@bcoca @ansibot @s-hertel