Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_snmp_community issues #39258

Merged
merged 1 commit into from Apr 25, 2018
Merged

fix nxos_snmp_community issues #39258

merged 1 commit into from Apr 25, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Apr 24, 2018 •
edited

SUMMARY

Fixes #39257

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_snmp_community

ANSIBLE VERSION
ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2018

cc @GGabriele @jedelman8 @mattclay @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Apr 24, 2018
@trishnaguha trishnaguha self-assigned this Apr 25, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Apr 25, 2018
@trishnaguha trishnaguha merged commit 1afec5a into ansible:devel Apr 25, 2018
@trishnaguha trishnaguha added this to Need CP into 2.5.2 in zzz NOT USED: Networking Bugs Apr 25, 2018
@saichint saichint deleted the snmp branch April 25, 2018 18:22
@trishnaguha trishnaguha moved this from Need CP into 2.5.3 to Done in zzz NOT USED: Networking Bugs May 4, 2018
@trishnaguha
Copy link
Member

cherry-picked to 2.5

trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request May 4, 2018
@trishnaguha
fix nxos_snmp_community issues (ansible#39258)
3fcc905 
(cherry picked from commit 1afec5a)
trishnaguha added a commit that referenced this pull request May 4, 2018
@trishnaguha
nxos bugfixes stable-2.5 (#39719)
6956420 
* Handle nxos_feature issue where json isn't supported (#39150)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 9eff1f1)

* Integration Tests only: nxos_snmp_contact (#39318)

* add integration test cases for snmp_contact

* removing unnecessary files

(cherry picked from commit bdb75cd)

* fix nxos_ntp issues (#39178)

* fix nxos_ntp issues

* review comments

* fix idempotent fail case

(cherry picked from commit 2f99a17)

* nxos_interface: AttributeError: 'NoneType' object has no attribute 'group' (#38544)

This fixes an issue we recently encounteredi with nxos_interface:

```
Traceback (most recent call last):
  File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 777, in main
    have = map_config_to_obj(want, module)
  File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 606, in map_config_to_obj
    obj['speed'] = re.search(r'speed (\d+)', body).group(1)
AttributeError: 'NoneType' object has no attribute 'group'
```

(cherry picked from commit dca6e2d)

* fix nxos_snmp_community issues (#39258)

(cherry picked from commit 1afec5a)

* Add aggregate example in nxos_l2_interface module doc (#39275)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 86817cd)

* Fix misuse of 'self' in lib/ansible/module_utils/network/eos/eos.py. … (#39074)

* Fix misuse of 'self' in lib/ansible/module_utils/network/eos/eos.py. Method load_config

* Fix all instances of self.config(self,...

(cherry picked from commit 80d7e22)

* Fix for nxos_snmp_host issues (#39642)

* fix snmp_host issues

* source files

* fix shippable

* remove defaults to match arg spec

(cherry picked from commit f99bae1)

* fix nxos_snmp_traps issues (#39444)

* fix snmp_traps code

* add IT cases

* fix shippable

* fix shippable without ignore

(cherry picked from commit 99748cb)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
fix nxos_snmp_community issues (ansible#39258)
987c4ce
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
fix nxos_snmp_community issues (ansible#39258)
fd60400
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
fix nxos_snmp_community issues (ansible#39258)
198b8dc
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
fix nxos_snmp_community issues (ansible#39258)
99a9481
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
fix nxos_snmp_community issues (ansible#39258)
85f53cf
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
fix nxos_snmp_community issues (ansible#39258)
e915879
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_snmp_community issues
4 participants
@saichint @ansibot @trishnaguha @dagwieers