-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nxos_snmp_community issues #39258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
networking
Network category
nxos
Cisco NXOS community
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
support:network
This issue/PR relates to code supported by the Ansible Network Team.
test
This PR relates to tests.
labels
Apr 24, 2018
trishnaguha
removed
the
needs_triage
Needs a first human triage before being processed.
label
Apr 25, 2018
trishnaguha
approved these changes
Apr 25, 2018
cherry-picked to 2.5 |
trishnaguha
pushed a commit
to trishnaguha/ansible
that referenced
this pull request
May 4, 2018
(cherry picked from commit 1afec5a)
trishnaguha
added a commit
that referenced
this pull request
May 4, 2018
* Handle nxos_feature issue where json isn't supported (#39150) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 9eff1f1) * Integration Tests only: nxos_snmp_contact (#39318) * add integration test cases for snmp_contact * removing unnecessary files (cherry picked from commit bdb75cd) * fix nxos_ntp issues (#39178) * fix nxos_ntp issues * review comments * fix idempotent fail case (cherry picked from commit 2f99a17) * nxos_interface: AttributeError: 'NoneType' object has no attribute 'group' (#38544) This fixes an issue we recently encounteredi with nxos_interface: ``` Traceback (most recent call last): File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 777, in main have = map_config_to_obj(want, module) File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 606, in map_config_to_obj obj['speed'] = re.search(r'speed (\d+)', body).group(1) AttributeError: 'NoneType' object has no attribute 'group' ``` (cherry picked from commit dca6e2d) * fix nxos_snmp_community issues (#39258) (cherry picked from commit 1afec5a) * Add aggregate example in nxos_l2_interface module doc (#39275) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 86817cd) * Fix misuse of 'self' in lib/ansible/module_utils/network/eos/eos.py. … (#39074) * Fix misuse of 'self' in lib/ansible/module_utils/network/eos/eos.py. Method load_config * Fix all instances of self.config(self,... (cherry picked from commit 80d7e22) * Fix for nxos_snmp_host issues (#39642) * fix snmp_host issues * source files * fix shippable * remove defaults to match arg spec (cherry picked from commit f99bae1) * fix nxos_snmp_traps issues (#39444) * fix snmp_traps code * add IT cases * fix shippable * fix shippable without ignore (cherry picked from commit 99748cb) * changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
This issue/PR relates to a bug.
cisco
Cisco technologies
core_review
In order to be merged, this PR must follow the core review workflow.
module
This issue/PR relates to a module.
networking
Network category
nxos
Cisco NXOS community
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
support:network
This issue/PR relates to code supported by the Ansible Network Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #39257
ISSUE TYPE
COMPONENT NAME
nxos_snmp_community
ANSIBLE VERSION
ADDITIONAL INFORMATION