Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_linkagg normalize interface #39591

Merged
merged 1 commit into from May 8, 2018
Merged

nxos_linkagg normalize interface #39591

merged 1 commit into from May 8, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented May 2, 2018 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #39408
Passes integration tests.

Handles the following cases:

  • Case insensitive (should accept upper and lower case names)
  • Abbreviated or short form of the interface names.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_linkagg

ANSIBLE VERSION
devel, 2.5

@trishnaguha
nxos_linkagg normalize interface
22bbc4a 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha requested a review from Qalthos May 2, 2018 07:50
@trishnaguha trishnaguha mentioned this pull request May 2, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented May 2, 2018

cc @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 2, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label May 2, 2018
@trishnaguha trishnaguha merged commit 3c35dd4 into ansible:devel May 8, 2018
@trishnaguha trishnaguha deleted the nxos_linkagg_abbreviated_form branch May 8, 2018 05:45
@trishnaguha
Copy link
Member Author

cherry-picked to 2.5

trishnaguha added a commit to trishnaguha/ansible that referenced this pull request May 8, 2018
@trishnaguha
nxos_linkagg normalize interface (ansible#39591)
e2dfdac 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 3c35dd4)
trishnaguha added a commit that referenced this pull request May 8, 2018
@trishnaguha
nxos and ios bugfix stable-2.5 (#39845)
079b7cb 
* nxos_linkagg normalize interface (#39591)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 3c35dd4)

* use show run instead of section pipeline ios_l2_interface (#39658)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit dddcbb7)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_snmp_user issues (#39760)

* fix nxos_snmp_user issues

* shipppable fix

(cherry picked from commit e3bfbe5)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix shippable

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@trishnaguha
nxos_linkagg normalize interface (ansible#39591)
a42a668 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@trishnaguha
nxos_linkagg normalize interface (ansible#39591)
ea8d652 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@trishnaguha
nxos_linkagg normalize interface (ansible#39591)
1acb0b3 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@trishnaguha
nxos_linkagg normalize interface (ansible#39591)
df11958 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@trishnaguha
nxos_linkagg normalize interface (ansible#39591)
07d9660 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@trishnaguha
nxos_linkagg normalize interface (ansible#39591)
83240d8 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@trishnaguha @ilicmilan
nxos_linkagg normalize interface (ansible#39591)
95690c3 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_linkagg is not consistent
3 participants
@trishnaguha @ansibot @dagwieers