use show run instead of section pipeline ios_l2_interface #39658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
trishnaguha
removed
the
needs_triage
mrlesmithjr
reviewed
May 4, 2018
| @@ -146,7 +146,7 @@ def is_switchport(name, module): | |||
|
|
|||
| def interface_is_portchannel(name, module): | |||
| if get_interface_type(name) == 'ethernet': | |||
| config = get_config(module, flags=[' | section interface']) | |||
| config = run_commands(module, ['show run interface {0}'.format(name)])[0] | |||
| if 'channel group' in config: | |||
There was a problem hiding this comment.
It looks like this should be added possibly or something similar?
if 'channel group' in config:
return True
elif 'channel-group' in config:
return TrueThere was a problem hiding this comment.
@mrlesmithjr Thanks for bringing up the other scenario. The latest commit should fix that.
There was a problem hiding this comment.
Works as it should! Great job!
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
ios_l2_interface_fix
branch
from
e2dc2da
to
9ba36b3
Compare
|
cherry-picked to 2.5 |
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
May 8, 2018
) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit dddcbb7)
trishnaguha
added a commit
that referenced
this pull request
May 8, 2018
* nxos_linkagg normalize interface (#39591) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 3c35dd4) * use show run instead of section pipeline ios_l2_interface (#39658) Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit dddcbb7) * add changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * fix nxos_snmp_user issues (#39760) * fix nxos_snmp_user issues * shipppable fix (cherry picked from commit e3bfbe5) * changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * fix shippable Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
fixes #39011
| sectionisn't supported in older IOS devices, useshow run interfaceinstead.ISSUE TYPE
COMPONENT NAME
modules/network/ios/ios_l2_interface.py
ANSIBLE VERSION