Fix eos_vlan associated interface check #39661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
ganeshrn
removed
the
needs_triage
gundalow
reviewed
May 3, 2018
| @@ -225,7 +225,7 @@ def map_config_to_obj(module): | |||
| interfaces = vlans[0]['vlans'][vlan] | |||
|
|
|||
| for interface in interfaces['interfaces']: | |||
| obj['interfaces'].append(interface) | |||
There was a problem hiding this comment.
Do we need this in the other vlan modules?
Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower
ganeshrn
force-pushed
the
eos_integration_test_fixes
branch
from
3de8e1b
to
d8092c6
Compare
gundalow
approved these changes
May 3, 2018
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
May 4, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs * Update changelog (cherry picked from commit afdc236)
ganeshrn
added a commit
that referenced
this pull request
May 4, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs * Update changelog (cherry picked from commit afdc236)
ganeshrn
moved this from In Review
to Need CP into 2.5.3
in zzz NOT USED: Networking Bugs
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs
tonal
pushed a commit
to tonal/ansible
that referenced
this pull request
May 15, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* Fix eos_vlan associated interface check Fix eos_vlan associated interface check by comparing the interface in want and have without converting the interface name to lower * Update eos_vlan docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
the interface in want and have by converting the name
to lower
ISSUE TYPE
COMPONENT NAME
eos_vlan
ANSIBLE VERSION
ADDITIONAL INFORMATION