Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IT cases for nxos_logging #39929

Merged
merged 2 commits into from May 11, 2018
Merged

IT cases for nxos_logging #39929

merged 2 commits into from May 11, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented May 9, 2018

SUMMARY

IT cases for nxos_logging

ISSUE TYPE
  • IT pull request
COMPONENT NAME

nxos_logging

ANSIBLE VERSION
ansible 2.6.0 (devel 8c819dd9cb) last updated 2018/03/21 18:16:48 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
  • This PR is for enhancing integration test cases for nxos_logging module.
  • All tests pass on all platforms.
  • There are no code changes.

@ansibot
Copy link
Contributor

ansibot commented May 9, 2018

cc @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels May 9, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 10, 2018
trishnaguha
trishnaguha reviewed May 10, 2018
View reviewed changes
test/integration/targets/nxos_logging/tests/common/basic.yaml Outdated
- { dest: module, dest_level: 2, state: absent }
- { dest: monitor, dest_level: 3, state: absent }
- { dest: logfile, dest_level: 1, name: test, state: absent }
- { facility: daemon, facility_level: 4, state: absent }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since state: absent is common with all the aggregate items, right way to frame this is as follows:

 - name: remove logging as collection tearDown
   nxos_logging: &agg
     aggregate:
-      - { dest: console, dest_level: 0, state: absent }
-      - { dest: module, dest_level: 2, state: absent }
-      - { dest: monitor, dest_level: 3, state: absent }
-      - { dest: logfile, dest_level: 1, name: test, state: absent }
-      - { facility: daemon, facility_level: 4, state: absent }
+      - { dest: console, dest_level: 0 }
+      - { dest: module, dest_level: 2 }
+      - { dest: monitor, dest_level: 3 }
+      - { dest: logfile, dest_level: 1, name: test }
+      - { facility: daemon, facility_level: 4 }
+    state: absent
     provider: "{{ connection }}"
   register: result

@saichint
Copy link
Contributor Author

@trishnaguha Thanks for the comments. Made the changes.

@trishnaguha trishnaguha merged commit 2557c06 into ansible:devel May 11, 2018
@trishnaguha trishnaguha self-assigned this May 11, 2018
@trishnaguha trishnaguha added this to Need CP into 2.5.3 in zzz NOT USED: Networking Bugs May 11, 2018
@saichint saichint deleted the logging branch May 11, 2018 15:35
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
IT cases for nxos_logging (ansible#39929)
ac499e9 
* IT cases for nxos_logging

* review comment
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
IT cases for nxos_logging (ansible#39929)
20e5102 
* IT cases for nxos_logging

* review comment
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
IT cases for nxos_logging (ansible#39929)
b6cf989 
* IT cases for nxos_logging

* review comment
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
IT cases for nxos_logging (ansible#39929)
1954b25 
* IT cases for nxos_logging

* review comment
@trishnaguha
Copy link
Member

cherry-picked to 2.5

@trishnaguha trishnaguha moved this from Need CP into 2.5.3 to Done in zzz NOT USED: Networking Bugs May 15, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request May 15, 2018
@trishnaguha
IT cases for nxos_logging (ansible#39929)
6347d2a 
* IT cases for nxos_logging

* review comment

(cherry picked from commit 2557c06)
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
IT cases for nxos_logging (ansible#39929)
e461ea3 
* IT cases for nxos_logging

* review comment
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
IT cases for nxos_logging (ansible#39929)
a7a2ed6 
* IT cases for nxos_logging

* review comment
trishnaguha added a commit that referenced this pull request May 16, 2018
@trishnaguha
cherry-pick stable-2.5 (#40177)
299047d 
* Fix nxos terminal plugin regex (#39659)

Fix nxos terminal plugin regex to match
command prompt without newline character as prefix

(cherry picked from commit 0ac222d)

* remove purge from nxos_logging doc, argspec (#39947)

* remove purge from nxos_logging doc, argspec

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* shippable

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit f1103a7)

* IT cases for nxos_logging (#39929)

* IT cases for nxos_logging

* review comment

(cherry picked from commit 2557c06)

* fix nxos_ping issues (#40028)

(cherry picked from commit 6fac574)

* Fix vxlan_vtep_vni tests (#39968)

(cherry picked from commit 0407c51)

* ios cliconf plugin fix regex for version (#40066)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 5cf61d7)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* shippable

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
IT cases for nxos_logging (ansible#39929)
4d501af 
* IT cases for nxos_logging

* review comment
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saichint @ansibot @trishnaguha @dagwieers @jborean93