Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vxlan_vtep_vni tests #39968

Merged

Conversation

mikewiebe
Copy link
Contributor

@mikewiebe mikewiebe commented May 10, 2018

SUMMARY

In later versions of Nexus, the host_reachability under the nve interface must be set property for the desired ingress_replication setting.

  • To set ingress_replication to bgp, host_reachability must be set to True
  • To set ingress_replication to static, host_reachability must be set to False

Older version of Nexus did not enforce this. These change work with the latest and also older versions of Nexus that support vxlan.

Nexus will not allow you to simply toggle the host_reachability setting so in the tests we remove the vtep and reconfigure with the correct setting.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_vxlan_vtep_vni

ANSIBLE VERSION
ansible 2.6.0 (rel260/fix_vxlan_vtep_vni 168416cad0) last updated 2018/05/10 12:03:41 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/Users/mwiebe/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/lib/ansible
  executable location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/bin/ansible
  python version = 2.7.13 (default, Apr  4 2017, 08:47:57) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.38)]
ADDITIONAL INFORMATION

All tests pass.

@mikewiebe
Copy link
Contributor Author

@trishnaguha Please cherry-pick this into 2.5 MR.

@ansibot
Copy link
Contributor

ansibot commented May 10, 2018

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels May 10, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 11, 2018
@trishnaguha trishnaguha self-assigned this May 11, 2018
@trishnaguha trishnaguha merged commit 0407c51 into ansible:devel May 14, 2018
@trishnaguha trishnaguha moved this from In Review to Need CP into 2.5.3 in zzz NOT USED: Networking Bugs May 14, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@trishnaguha
Copy link
Member

cherry-picked to 2.5

@trishnaguha trishnaguha moved this from Need CP into 2.5.3 to Done in zzz NOT USED: Networking Bugs May 15, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request May 15, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
trishnaguha added a commit that referenced this pull request May 16, 2018
* Fix nxos terminal plugin regex (#39659)

Fix nxos terminal plugin regex to match
command prompt without newline character as prefix

(cherry picked from commit 0ac222d)

* remove purge from nxos_logging doc, argspec (#39947)

* remove purge from nxos_logging doc, argspec

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* shippable

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit f1103a7)

* IT cases for nxos_logging (#39929)

* IT cases for nxos_logging

* review comment

(cherry picked from commit 2557c06)

* fix nxos_ping issues (#40028)

(cherry picked from commit 6fac574)

* Fix vxlan_vtep_vni tests (#39968)

(cherry picked from commit 0407c51)

* ios cliconf plugin fix regex for version (#40066)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 5cf61d7)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* shippable

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@mikewiebe mikewiebe deleted the rel260/fix_vxlan_vtep_vni branch November 26, 2018 18:06
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. cisco Cisco technologies networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants