Update cron.py

[Loreton]

[Please refer to PR #39954]

If the line that we need to insert already exists but the number of BLANKs that separate the fields is different from the new line, a duplicated line will be inserted.

SUMMARY

Try to find out if a row already exists ignoring the number of BLANKs that separate the individual fields. If the entry already exists, the job name will be inserted.
To do that extra BLANKs inside new_line and old_line are removed before comparing them.
I tested it with a classical entry and with a special_time "@reboot" entry.

ISSUE TYPE

• Feature Pull Request
• New Module Pull Request
• Bugfix Pull Request
• Docs Pull Request

COMPONENT NAME

cron.py

ANSIBLE VERSION

ansible 2.5.0
  config file = /home/pi/GIT-REPO/Ansible/PiAnsible/playbooks/ansible.cfg
  configured module search path = [u'/home/pi/GIT-REPO/Ansible/PiAnsible/library']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.3 (default, Nov 24 2017, 21:13:24) [GCC 4.6.3]

ADDITIONAL INFORMATION

************************ using CURRENT module ************************:
--- crontab before  run ---
05     22  *     *     *      sudo shutdown -h now


--- crontab after run ---
05     22  *     *     *      sudo shutdown -h now
#Ansible: shutdown
05 22 * * * sudo shutdown -h now

************************ using NEW module ************************
--- crontab before  run ---
05     22  *     *     *      sudo shutdown -h now

--- crontab after run ---
#Ansible: shutdown
05 22 * * * sudo shutdown -h now

[ansibot]

cc @EvanK @dsummersl @lberruti
click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/system/cron.py:393:43: multiple-statements More than one statement on a single line

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/system/cron.py:393:42: E701 multiple statements on one line (colon)
lib/ansible/modules/system/cron.py:395:34: E225 missing whitespace around operator
lib/ansible/modules/system/cron.py:395:54: E261 at least two spaces before inline comment
lib/ansible/modules/system/cron.py:396:59: E261 at least two spaces before inline comment
lib/ansible/modules/system/cron.py:396:60: E262 inline comment should start with '# '

click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/system/cron.py:393:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/system/cron.py:396:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/system/cron.py:393:43: W291 trailing whitespace
lib/ansible/modules/system/cron.py:396:59: W291 trailing whitespace

click here for bot help

[ansibot]

cc @dirtyharrycallahan @rhaido
click here for bot help

[ansibot]

@Loreton Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

[ansibot]

@Loreton Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

[gundalow]

@Loreton Will you be able to still work on this PR?
needs_info

[Loreton]

I'm sorry but I discarded ansible environment and at this moment I cannot run any test. If you need info and tests are not necessary, please ask me and I'll try to answer. Regards Loreto Il mar 3 set 2019, 13:03 John R Barker <notifications@github.com> ha scritto:

…

@Loreton <https://github.com/Loreton> Will you be able to still work on this PR? needs_info — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40003?email_source=notifications&email_token=ABL47GFEZLCRJL6KKS4QXSTQHZAAPA5CNFSM4E7MPDR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5X2MQI#issuecomment-527410753>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABL47GFP2QFDHDCK4VMNT43QHZAAPANCNFSM4E7MPDRQ> .

[gundalow]

@Loreton Thank you for your comment. I think we'd need tests for this, which I understand you don't have time for at the moment, which is OK.

Therefore I'll close this PR.

A new PR in the future that includes integrations tests would be welcome.