Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy Nexus 3k integration test and module issues. #40322

Merged
merged 6 commits into from May 17, 2018
Merged

Fix legacy Nexus 3k integration test and module issues. #40322

merged 6 commits into from May 17, 2018

Conversation

mikewiebe
Copy link
Contributor

SUMMARY

This PR fixes several bugs in devel for Legacy N3Ks

  • Fixes a defect in nxos_facts for parsing fan data.
  • Adds new platform tag N3L to represent legacy N3K's in prepare_nxos_tests.
  • Skips integration test steps that are not applicable to N3L platform type.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Various nxos_* modules

ANSIBLE VERSION
ansible 2.6.0 (rel260/nxos_fixes 556f6e6e46) last updated 2018/05/17 09:19:23 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/Users/mwiebe/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/lib/ansible
  executable location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/bin/ansible
  python version = 2.7.13 (default, Apr  4 2017, 08:47:57) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.38)]

@ansibot
Copy link
Contributor

ansibot commented May 17, 2018

cc @GGabriele @jedelman8 @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels May 17, 2018
@trishnaguha trishnaguha self-assigned this May 17, 2018
@trishnaguha trishnaguha added this to Need CP into 2.5.3 in zzz NOT USED: Networking Bugs May 17, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label May 17, 2018
@trishnaguha trishnaguha merged commit 63e1643 into ansible:devel May 17, 2018
@trishnaguha
Copy link
Member

We will cherry-pick this to 2.5.4

achinthagunasekara pushed a commit to achinthagunasekara/ansible that referenced this pull request May 23, 2018
@mikewiebe @achinthagunasekara
Fix legacy Nexus 3k integration test and module issues. (ansible#40322)
7dfd72d 
* Add setup ignore_errors for nxos_config test

* Fix parse_fan_info for n3k

* Skip bidir tests for N3k

* Omit vni config for n3k

* Skip unsupported nxos_vrf_af test on N3K

* Add legacy N3K platform tag
@trishnaguha trishnaguha moved this from Need CP into 2.5.3 to Done in zzz NOT USED: Networking Bugs May 30, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request May 30, 2018
@mikewiebe @trishnaguha
Fix legacy Nexus 3k integration test and module issues. (ansible#40322)
060888b 
* Add setup ignore_errors for nxos_config test

* Fix parse_fan_info for n3k

* Skip bidir tests for N3k

* Omit vni config for n3k

* Skip unsupported nxos_vrf_af test on N3K

* Add legacy N3K platform tag

(cherry picked from commit 63e1643)
trishnaguha added a commit that referenced this pull request May 30, 2018
@trishnaguha
nxos bugfixes 2.5.4 cherry-pick (#40861)
8e8b469 
* Fix legacy Nexus 3k integration test and module issues. (#40322)

* Add setup ignore_errors for nxos_config test

* Fix parse_fan_info for n3k

* Skip bidir tests for N3k

* Omit vni config for n3k

* Skip unsupported nxos_vrf_af test on N3K

* Add legacy N3K platform tag

(cherry picked from commit 63e1643)

* Skip N35 and N3L platforms for nxos_evpn_global test (#40333)

(cherry picked from commit ad69ef8)

* add normalize_interface in module_utils and fix nxos_l3_interface module (#40598)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 0b7932d)

* nxos_interface: Disable switchport for loopback/svi (#40314)

* nxos_interface: Disable switchport for loopback/svi

* Replace interface_type with get_interface_type(name)

(cherry picked from commit d04a989)

* fixes bug with matching nxos prompts (#40655)

This change addresses an issue where the prompt matching regular
expressions would not match a prompt if the hostname starts with a
numeric value.  Before this change, the connection would fail with a
socket.timeout() error.  This change updates the termnal_stdout_re
values to now check for a number.

See Github issue #38639

(cherry picked from commit d829ff6)

* fix nxos_vrf and migrate get_interface_type to module_utils (#40825)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit b4baa2d)

* nxos_vlan fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* changelog nxos bugfixes 2.5.4

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha mentioned this pull request Jun 16, 2018
Closed
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@mikewiebe
Fix legacy Nexus 3k integration test and module issues. (ansible#40322)
bb55fe4 
* Add setup ignore_errors for nxos_config test

* Fix parse_fan_info for n3k

* Skip bidir tests for N3k

* Omit vni config for n3k

* Skip unsupported nxos_vrf_af test on N3K

* Add legacy N3K platform tag
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@mikewiebe @ilicmilan
Fix legacy Nexus 3k integration test and module issues. (ansible#40322)
d48fc99 
* Add setup ignore_errors for nxos_config test

* Fix parse_fan_info for n3k

* Skip bidir tests for N3k

* Omit vni config for n3k

* Skip unsupported nxos_vrf_af test on N3K

* Add legacy N3K platform tag
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikewiebe @ansibot @trishnaguha @dagwieers